<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Looks fine to me now.<br>
Thanks,<br>
Valerie<br>
<br>
On 06/13/13 05:35, John Zavgren wrote:
<blockquote cite="mid:51B9BC75.1030100@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
All:<br>
Please give this change one more consideration. <br>
<br>
Thanks!<br>
John<br>
<div class="moz-forward-container"><br>
<br>
-------- Original Message --------
<table class="moz-email-headers-table" border="0"
cellpadding="0" cellspacing="0">
<tbody>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">Subject:
</th>
<td>Re: Re: RFR JDK-8014307</td>
</tr>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">Date:
</th>
<td>Fri, 24 May 2013 15:56:11 -0400</td>
</tr>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">From:
</th>
<td>John Zavgren <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:john.zavgren@oracle.com"><john.zavgren@oracle.com></a></td>
</tr>
<tr>
<th nowrap="nowrap" valign="BASELINE" align="RIGHT">To: </th>
<td>Security-Dev <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:security-dev@openjdk.java.net"><security-dev@openjdk.java.net></a></td>
</tr>
</tbody>
</table>
<br>
<br>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Thanks, Valerie. I removed the unnecessary resetGSSBuffer(...)
call. The revised webrev is viewable at:<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ejzavgren/8014307/webrev.03/">http://cr.openjdk.java.net/~jzavgren/8014307/webrev.03/</a><br>
<br>
John<br>
<blockquote cite="mid:519FB1DE.90607@oracle.com" type="cite">--------
Original Message -------- <br>
Subject: Re: RFR JDK-8014307 <br>
Date: Wed, 22 May 2013 16:18:33 -0700 <br>
From: Valerie (Yu-Ching) Peng <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:valerie.peng@oracle.com"><valerie.peng@oracle.com></a>
<br>
Reply-To: <a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:valerie.peng@oracle.com">valerie.peng@oracle.com</a>
<br>
To: <a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:security-dev@openjdk.java.net">security-dev@openjdk.java.net</a>
<br>
<br>
<br>
<br>
The resetGSSBuffer(..) call on line 829 should be removed as
the inToken <br>
structure isn't even initialized yet (initGSSBuffer call is on
line 833). <br>
Rest looks fine. <br>
Thanks, <br>
Valerie <br>
<br>
On 05/22/13 11:54, John Zavgren wrote: <br>
<blockquote type="cite">Greetings: <br>
I just updated: <br>
/jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c
<br>
/with the recommended changes. <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejzavgren/8014307/webrev.02/">http://cr.openjdk.java.net/~jzavgren/8014307/webrev.02/</a>
<br>
<br>
Thanks! <br>
John Zavgren <br>
----------------------------------------------------------------------
<br>
<br>
<br>
John, <br>
<br>
1) 332-333 can be replaced w/ a deleteGSSOID(nameType) call.
Also, with <br>
this deleteGSSOID(nameType) call, we should also add the
following line: <br>
resetGSSBuffer(env, jnameVal, &nameVal); <br>
<br>
2) I think the ExceptionCheck block on line 932 should also
be enhanced <br>
w/ resetGSSBuffer(env, jinToken, &inToken) call as well
as free(cb) <br>
call. Same goes for another ExceptionCheck blocks on line
984, 998, 1024. <br>
<br>
Thanks, <br>
Valerie <br>
On 05/14/13 19:19, John Zavgren wrote: <br>
>/ Greetings: Please review the following change to the
file: <br>
/>/
jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c
that fixes <br>
/>/ two memory leaks. <br>
/>/ <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejzavgren/8014307/webrev.01/">http://cr.openjdk.java.net/~jzavgren/8014307/webrev.01/</a>
<a moz-do-not-send="true" class="moz-txt-link-rfc2396E"
href="http://cr.openjdk.java.net/%7Ejzavgren/8014307/webrev.01/"><http://cr.openjdk.java.net/%7Ejzavgren/8014307/webrev.01/></a>
Thanks! John <br>
/>/ Zavgren/ <br>
-- <br>
John Zavgren <br>
<a moz-do-not-send="true" class="moz-txt-link-abbreviated"
href="mailto:john.zavgren@oracle.com">john.zavgren@oracle.com</a>
<br>
603-821-0904 <br>
US-Burlington-MA <br>
</blockquote>
<br>
<br>
<br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
John Zavgren
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:john.zavgren@oracle.com">john.zavgren@oracle.com</a>
603-821-0904
US-Burlington-MA</pre>
<br>
</div>
<br>
</blockquote>
<br>
</body>
</html>