<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Max<br>
<br>
I updated the webrev:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a
href="http://1.smotrakov.z8.ru/8016051/webrev.01/src/share/classes/sun/security/krb5/KdcComm.java.udiff.html">http://1.smotrakov.z8.ru/8016051/webrev.01/src/share/classes/sun/security/krb5/KdcComm.java.udiff.html</a><br>
<br>
I built OpenJDK on Linux x64 according to
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a
href="http://hg.openjdk.java.net/jdk8/build/raw-file/tip/README-builds.html">http://hg.openjdk.java.net/jdk8/build/raw-file/tip/README-builds.html</a>,
and ran JCK, SQE (related to Kerberos), jdk_security tests (listed
in
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a
href="http://hg.openjdk.java.net/jdk8/build/raw-file/tip/README-builds.html">http://hg.openjdk.java.net/jdk8/build/raw-file/tip/README-builds.html</a>)<br>
<br>
Artem<br>
<br>
On 25.06.2013 16:04, Weijun Wang wrote:<br>
</div>
<blockquote cite="mid:51C98769.5090005@oracle.com" type="cite">Hi
Artem
<br>
<br>
Line 221 is a little too long, you may want to break it.
Otherwise, fine.
<br>
<br>
Have you tried running JPRT with at least the jdk_security test?
<br>
<br>
Thanks
<br>
Max
<br>
<br>
<br>
On 6/25/2013 1:35 PM, Artem Smotrakov wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
please review this fix for 8:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016051">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016051</a>
<br>
<a class="moz-txt-link-freetext" href="http://1.smotrakov.z8.ru/8016051/webrev.00/">http://1.smotrakov.z8.ru/8016051/webrev.00/</a>
<br>
<br>
It fixes a possible ClassCastException if an exception thrown
from
<br>
send() method is not IOException or KrbException. The first
exception is
<br>
thrown if all connections to KDC fail. See also:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/017714.html">http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/017714.html</a>
<br>
<br>
Artem
<br>
</blockquote>
</blockquote>
<br>
</body>
</html>