<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Thanks for your reviews. I’ve made a minor change to include a message in<div>the CPVE, as suggested by Max.</div><div><br></div><div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">% hg diff OCSPResponse.java</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">diff --git a/src/share/classes/sun/security/provider/certpath/OCSPResponse.java b/src/share/classes/sun/security/provider/certpath/OCSPResponse.java</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">--- a/src/share/classes/sun/security/provider/certpath/OCSPResponse.java</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">+++ b/src/share/classes/sun/security/provider/certpath/OCSPResponse.java</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">@@ -427,9 +427,14 @@ public final class OCSPResponse {</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> if (signerCert == null) {</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> // Add the Issuing CA cert and/or Trusted Responder cert to the list</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> // of certs from the OCSP response</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">- certs.add((X509CertImpl) issuerCert);</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">- if (responderCert != null) {</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">- certs.add((X509CertImpl) responderCert);</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">+ try {</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">+ certs.add(X509CertImpl.toImpl(issuerCert));</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">+ if (responderCert != null) {</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">+ certs.add(X509CertImpl.toImpl(responderCert));</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">+ }</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">+ } catch (CertificateException ce) {</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">+ throw new CertPathValidatorException(</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">+ "Invalid issuer or trusted responder certificate", ce);</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> }</div><p style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"> <br class="webkit-block-placeholder"></p><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> if (responderName != null) {</div><div><br></div><div><br></div><div><br></div><div><div>On 10 Dec 2013, at 01:44, Weijun Wang <<a href="mailto:weijun.wang@oracle.com">weijun.wang@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">It looks good. Would you like to add a string message?<br><br>Thanks<br>Max<br><br>On 12/10/13, 9:47, Jason Uh wrote:<br><blockquote type="cite">Hi Vinnie,<br><br>The change looks good to me.<br><br>Jason<br>(Not an official Reviewer)<br><br>On 12/9/13 3:25 PM, Vincent Ryan wrote:<br><blockquote type="cite"><br>Please review this fix to the OCSPResponse class in the internal<br>sun.security.provider.certpath package. Previously, when validating<br>an OCSP response, it expected the supplied issuer and/or trusted<br>responder X509 certs to already be in an internal format used by<br>the package. Now it accepts certs in any subclass of X509Certificate<br>and will convert to the internal format, if necessary.<br><br>Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8029788">https://bugs.openjdk.java.net/browse/JDK-8029788</a><br>Webrev: <a href="http://cr.openjdk.java.net/~vinnie/8029788/webrev.00/">http://cr.openjdk.java.net/~vinnie/8029788/webrev.00/</a><br><br>This fixes a regression introduced by JDK-8015571.<br>Thanks.<br></blockquote><br></blockquote></blockquote></div><br></div></body></html>