<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hello Vincent,<br>
<br>
Thanks for your feedback.<br>
<br>
I heve updated the webrev with the following:<br>
- the test moved to the existing
test/java/security/cert/X509Certificate/ directory<br>
- copyright in the test<br>
- copyright year at the start of DerValue.java<br>
<br>
There was no 'othervm' tag in the test. Did I miss something?<br>
<br>
Please take a look:
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a
href="http://cr.openjdk.java.net/%7Easmotrak/8028431/webrev.01/">http://cr.openjdk.java.net/~asmotrak/8028431/webrev.01/</a><br>
<br>
Artem<br>
<br>
On 12/20/2013 05:19 PM, Vincent Ryan wrote:<br>
</div>
<blockquote cite="mid:52B443D2.9080901@oracle.com" type="cite">Hello
Artem,
<br>
<br>
You fix looks good. You just need to fill in the missing portion
<br>
of the copyright in the test. You could also adjust the copyright
<br>
year range at the start of DerValue.java.
<br>
<br>
Also I would add the test to the existing
test/java/security/cert/X509Certificate/ directory rather than
create a new one.
<br>
<br>
Finally, I think the test should run fine without the jtreg
<br>
tag for 'othervm'.
<br>
<br>
Thanks.
<br>
<br>
<br>
On 20/12/2013 12:51, Artem Smotrakov wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
please review this fix for 9:
<br>
<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8028431">https://bugs.openjdk.java.net/browse/JDK-8028431</a>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~asmotrak/8028431/webrev.00/">http://cr.openjdk.java.net/~asmotrak/8028431/webrev.00/</a>
<br>
<a class="moz-txt-link-rfc2396E" href="http://cr.openjdk.java.net/%7Easmotrak/8028431/webrev.00/"><http://cr.openjdk.java.net/%7Easmotrak/8028431/webrev.00/></a>
<br>
<br>
sun.security.util.DerValue.equals(DerValue) method does not
check that
<br>
null is passed. As a result, NullPointerException can occur.
<br>
<br>
Artem
<br>
</blockquote>
</blockquote>
<br>
</body>
</html>