<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">It’s difficult to develop a useful test that is cross-platform so let’s skip the testcase for this fix.<div><div><br></div><div><br><div><div>On 28 May 2014, at 17:21, Jeremy Manson <<a href="mailto:jeremymanson@google.com">jeremymanson@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">You can defer the change if you need to. I'm going on vacation from the 6th to the 16th, so there are timing issues around that.<div><br></div><div>At Google, we plug in a different version of malloc that checks to make sure that you've freed everything you've allocated. It's a bit painful to write this from scratch, but I might be able to hack something together for you (that only runs on Linux), if you want.</div>
<div><br></div><div>Jeremy</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, May 28, 2014 at 8:52 AM, Vincent Ryan <span dir="ltr"><<a href="mailto:vincent.x.ryan@oracle.com" target="_blank">vincent.x.ryan@oracle.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">I’ll begin reviewing your changeset and get back to you.<div>Thanks.</div><div><br><div>
<div><div>On 28 May 2014, at 16:28, Jeremy Manson <<a href="mailto:jeremymanson@google.com" target="_blank">jeremymanson@google.com</a>> wrote:</div><br></div><div><blockquote type="cite"><div dir="ltr">
Ah, okay. Thanks, Iris. I should already know known that - Martin has explained it to me before.<div><br></div><div>Vincent - let me know how you want to proceed.</div><div><br></div><div>Jeremy</div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Tue, May 27, 2014 at 10:00 PM, Iris Clark <span dir="ltr"><<a href="mailto:iris.clark@oracle.com" target="_blank">iris.clark@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi, Jeremy.<br>
<br>
As an "Author", you can create a changeset but you can't push to the repo until you're a "Committer". Additional details about the differences between Author and Committer may be found here [1,2].<br>
<br>
The diffs to create a changeset are (of course) in your webrev. Your Sponsor can use that along with the "hg commit -u jmanson ..." to list you as the changeset Author. Alternatively, your Sponsor may want you to just send the output of "hg export -g" which would preserve information in the changeset header including the author, commit comment, etc.<br>
<br>
Thanks,<br>
iris<br>
<br>
[1]: <a href="http://openjdk.java.net/projects/#project-author" target="_blank">http://openjdk.java.net/projects/#project-author</a><br>
[2]: <a href="http://openjdk.java.net/projects/#project-committer" target="_blank">http://openjdk.java.net/projects/#project-committer</a><br>
<div><br>
-----Original Message-----<br>
From: Jeremy Manson [mailto:<a href="mailto:jeremymanson@google.com" target="_blank">jeremymanson@google.com</a>]<br>
Sent: Tuesday, May 27, 2014 2:19 PM<br>
To: Vincent Ryan<br>
Cc: OpenJDK; core-libs-dev<br>
Subject: Re: RFR: 8044059: Memory Leak in Elliptic Curve Private Key Generation<br>
<br>
Thanks, Vincent. This would be the first change I've made as an author, so I'm not sure what the process is. I think I just need someone to do the review, and then I can check it in?<br>
<br>
Jeremy<br>
<br>
<br>
On Tue, May 27, 2014 at 1:55 PM, Vincent Ryan <<a href="mailto:vincent.x.ryan@oracle.com" target="_blank">vincent.x.ryan@oracle.com</a>><br>
wrote:<br>
<br>
> Thanks Jeremy. I believe you have JDK 9 Author status so can sponsor<br>
> your fix if you wish.<br>
><br>
> On 27 May 2014, at 21:09, Jeremy Manson <<a href="mailto:jeremymanson@google.com" target="_blank">jeremymanson@google.com</a>> wrote:<br>
><br>
> > Just like the title says - every time you generate a new private<br>
> > key, you leak a little memory. Webrev here:<br>
> ><br>
> > <a href="http://cr.openjdk.java.net/~jmanson/8044059/webrev/" target="_blank">http://cr.openjdk.java.net/~jmanson/8044059/webrev/</a><br>
> ><br>
> > This is probably the wrong mailing list for this bug, but I expect<br>
> someone<br>
> > on this list will point me in the right direction.<br>
> ><br>
> > Jeremy<br>
><br>
><br>
</div></blockquote></div><br></div></div>
</blockquote></div></div><br></div></div></blockquote></div><br></div></div>
</blockquote></div><br></div></div></body></html>