<div dir="ltr">What's the rationale for removing the secondary version? Or I guess the question should really be: when are secondary versions useful? At least in the EE specs, the EE version plus the spec version are listed in many places like this.<br>
</div><div class="gmail_extra"><br clear="all"><div><div dir="ltr"><br>Cheers,<br>Paul</div></div>
<br><br><div class="gmail_quote">On Mon, Jun 23, 2014 at 3:50 PM, Henry Jen <span dir="ltr"><<a href="mailto:henry.jen@oracle.com" target="_blank">henry.jen@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
OK, I'll remove all @since JCE line, as the class already has @since 1.4 as Joe pointed out earlier.<br>
<br>
Uodated webrev at<br>
<br>
<a href="http://cr.openjdk.java.net/~henryjen/jdk9/8047721/2/webrev/" target="_blank">http://cr.openjdk.java.net/~<u></u>henryjen/jdk9/8047721/2/<u></u>webrev/</a><br>
<br>
Cheers,<br>
Henry<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
On 06/23/2014 10:04 AM, Bradford Wetmore wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I would prefer that JCE1.2 be pulled out completely in the Cipher*<br>
classes. I will be sending you a separate note about JCE logistics.<br>
<br>
Thanks for doing this cleanup.<br>
<br>
Brad<br>
<br>
<br>
On 6/20/2014 11:46 AM, Henry Jen wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
Please review a trivial webrev to add JDK version to @since in a format<br>
as Mark suggested[1].<br>
<br>
<a href="http://cr.openjdk.java.net/~henryjen/jdk9/8047721/0/webrev/" target="_blank">http://cr.openjdk.java.net/~<u></u>henryjen/jdk9/8047721/0/<u></u>webrev/</a><br>
<br>
[1] <a href="http://mail.openjdk.java.net/pipermail/jdk9-dev/2014-June/000806.html" target="_blank">http://mail.openjdk.java.net/<u></u>pipermail/jdk9-dev/2014-June/<u></u>000806.html</a><br>
<br>
Appened is the diff as in the webrev.<br>
<br>
Cheers,<br>
Henry<br>
<br>
<br>
diff --git a/src/share/classes/java/lang/<u></u>Package.java<br>
b/src/share/classes/java/lang/<u></u>Package.java<br>
--- a/src/share/classes/java/lang/<u></u>Package.java<br>
+++ b/src/share/classes/java/lang/<u></u>Package.java<br>
@@ -107,6 +107,7 @@<br>
* loader to be found.<br>
*<br>
* @see ClassLoader#definePackage<br>
+ * @since 1.2<br>
*/<br>
public class Package implements java.lang.reflect.<u></u>AnnotatedElement {<br>
/**<br>
diff --git a/src/share/classes/javax/<u></u>crypto/CipherInputStream.java<br>
b/src/share/classes/javax/<u></u>crypto/CipherInputStream.java<br>
--- a/src/share/classes/javax/<u></u>crypto/CipherInputStream.java<br>
+++ b/src/share/classes/javax/<u></u>crypto/CipherInputStream.java<br>
@@ -170,7 +170,7 @@<br>
* @return the next byte of data, or <code>-1</code> if the end<br>
of the<br>
* stream is reached.<br>
* @exception IOException if an I/O error occurs.<br>
- * @since JCE1.2<br>
+ * @since 1.4, JCE1.2<br>
*/<br>
public int read() throws IOException {<br>
if (ostart >= ofinish) {<br>
@@ -196,7 +196,7 @@<br>
* the stream has been reached.<br>
* @exception IOException if an I/O error occurs.<br>
* @see java.io.InputStream#read(byte[<u></u>], int, int)<br>
- * @since JCE1.2<br>
+ * @since 1.4, JCE1.2<br>
*/<br>
public int read(byte b[]) throws IOException {<br>
return read(b, 0, b.length);<br>
@@ -217,7 +217,7 @@<br>
* the stream has been reached.<br>
* @exception IOException if an I/O error occurs.<br>
* @see java.io.InputStream#read()<br>
- * @since JCE1.2<br>
+ * @since 1.4, JCE1.2<br>
*/<br>
public int read(byte b[], int off, int len) throws IOException {<br>
if (ostart >= ofinish) {<br>
@@ -254,7 +254,7 @@<br>
* @param n the number of bytes to be skipped.<br>
* @return the actual number of bytes skipped.<br>
* @exception IOException if an I/O error occurs.<br>
- * @since JCE1.2<br>
+ * @since 1.4, JCE1.2<br>
*/<br>
public long skip(long n) throws IOException {<br>
int available = ofinish - ostart;<br>
@@ -277,7 +277,7 @@<br>
* @return the number of bytes that can be read from this<br>
input stream<br>
* without blocking.<br>
* @exception IOException if an I/O error occurs.<br>
- * @since JCE1.2<br>
+ * @since 1.4, JCE1.2<br>
*/<br>
public int available() throws IOException {<br>
return (ofinish - ostart);<br>
@@ -292,7 +292,7 @@<br>
* stream.<br>
*<br>
* @exception IOException if an I/O error occurs.<br>
- * @since JCE1.2<br>
+ * @since 1.4, JCE1.2<br>
*/<br>
public void close() throws IOException {<br>
if (closed) {<br>
@@ -321,7 +321,7 @@<br>
* <code>mark</code> and <code>reset</code> methods.<br>
* @see java.io.InputStream#mark(int)<br>
* @see java.io.InputStream#reset()<br>
- * @since JCE1.2<br>
+ * @since 1.4, JCE1.2<br>
*/<br>
public boolean markSupported() {<br>
return false;<br>
diff --git a/src/share/classes/javax/<u></u>crypto/CipherOutputStream.java<br>
b/src/share/classes/javax/<u></u>crypto/CipherOutputStream.java<br>
--- a/src/share/classes/javax/<u></u>crypto/CipherOutputStream.java<br>
+++ b/src/share/classes/javax/<u></u>crypto/CipherOutputStream.java<br>
@@ -114,7 +114,7 @@<br>
*<br>
* @param b the <code>byte</code>.<br>
* @exception IOException if an I/O error occurs.<br>
- * @since JCE1.2<br>
+ * @since 1.4, JCE1.2<br>
*/<br>
public void write(int b) throws IOException {<br>
ibuffer[0] = (byte) b;<br>
@@ -138,7 +138,7 @@<br>
* @exception NullPointerException if <code>b</code> is null.<br>
* @exception IOException if an I/O error occurs.<br>
* @see javax.crypto.<u></u>CipherOutputStream#write(byte[<u></u>], int,<br>
int)<br>
- * @since JCE1.2<br>
+ * @since 1.4, JCE1.2<br>
*/<br>
public void write(byte b[]) throws IOException {<br>
write(b, 0, b.length);<br>
@@ -152,7 +152,7 @@<br>
* @param off the start offset in the data.<br>
* @param len the number of bytes to write.<br>
* @exception IOException if an I/O error occurs.<br>
- * @since JCE1.2<br>
+ * @since 1.4, JCE1.2<br>
*/<br>
public void write(byte b[], int off, int len) throws IOException {<br>
obuffer = cipher.update(b, off, len);<br>
@@ -174,7 +174,7 @@<br>
* the cipher's block size, no bytes will be written out.<br>
*<br>
* @exception IOException if an I/O error occurs.<br>
- * @since JCE1.2<br>
+ * @since 1.4, JCE1.2<br>
*/<br>
public void flush() throws IOException {<br>
if (obuffer != null) {<br>
@@ -198,7 +198,7 @@<br>
* stream.<br>
*<br>
* @exception IOException if an I/O error occurs.<br>
- * @since JCE1.2<br>
+ * @since 1.4, JCE1.2<br>
*/<br>
public void close() throws IOException {<br>
if (closed) {<br>
diff --git a/src/share/classes/javax/<u></u>naming/InitialContext.java<br>
b/src/share/classes/javax/<u></u>naming/InitialContext.java<br>
--- a/src/share/classes/javax/<u></u>naming/InitialContext.java<br>
+++ b/src/share/classes/javax/<u></u>naming/InitialContext.java<br>
@@ -125,7 +125,7 @@<br>
* @see Context<br>
* @see NamingManager#<u></u>setInitialContextFactoryBuilde<u></u>r<br>
* NamingManager.<u></u>setInitialContextFactoryBuilde<u></u>r<br>
- * @since JNDI 1.1 / Java 2 Platform, Standard Edition, v 1.3<br>
+ * @since 1.3, JNDI 1.1<br>
*/<br>
<br>
public class InitialContext implements Context {<br>
<br>
</blockquote></blockquote>
</div></div></blockquote></div><br></div>