<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 21/07/2014 09:22, Wang Weijun wrote:<br>
</div>
<blockquote
cite="mid:E48DA6CC-9389-40F5-8D18-112F8EA28199@oracle.com"
type="cite">
<pre wrap="">Please review the updated webrev at
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~weijun/8038089/webrev.01">http://cr.openjdk.java.net/~weijun/8038089/webrev.01</a>
Some comment changes. Some arguments rearrangement between classes.
The interface is still in sun.security.ssl. It will be easy to move it to somewhere else later. When module is introduced, we may need to export the interface from java.base to java.security.jgss.
</pre>
</blockquote>
I'm skimmed over the changes (not a detailed review yet) and just
want to check one thing - would I be correct to say that this isn't
a general solution for plugging in addition cipher suites, the
ServiceLoader usage in Krb5Helper looks specifically for a provider
that supports <span class="changed">TLS_KRB5_XXX</span>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
from what I can establish.<br>
<br>
One other thing about the ServiceLoader usage in Krb5Helper is that
it's using the one-arg load method, hence the TCCL will be used to
locate the cipher suite providers. As the provider is cached
system-wide then I assume you meant to specify the system class
loader here.<br>
<br>
The profiles build currently uses a simple dependency checker to
ensure that there aren't any dependencies in a compact N build on
something that is in a larger profile or the JRE. It allows a few
exceptions, due to the need to keep jsse.jar and these are
maintained in jdk/make/data/checkdeps/refs.allowed. I think this
file will need to be updated to drop references to classes that no
longer exist.<br>
<br>
A minor comment is that the new files are missing a copyright
header, I assume you'll fix that up before pushing.<br>
<br>
-Alan.<br>
</body>
</html>