<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello Max,<br>
<br>
Shouldn't the rule for $(GENDATA_JAVA_SECURITY) depend on
$(RESTRICTED_PKGS_SRC) so that updates to the pkgs file triggers a
rebuild? For that to work, the variable $(RESTRICTED_PKGS_SRC) needs
to be empty for the OPENJDK case rather than have a dummy name and
MakeJavaSecurity.java needs to handle missing the last argument.<br>
<br>
/Erik<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<div class="moz-cite-prefix">On 2014-07-28 03:44, Wang Weijun wrote:<br>
</div>
<blockquote
cite="mid:902FCDAA-E90B-4677-836C-D294D725FB45@oracle.com"
type="cite">
<pre wrap="">Webrev updated at
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~weijun/6997010/webrev.01/">http://cr.openjdk.java.net/~weijun/6997010/webrev.01/</a>
New test CheckSecurityProvider.java, and updates to MakeJavaSecurity.addPackages().
Thanks
Max
On Jul 25, 2014, at 22:44, Wang Weijun <a class="moz-txt-link-rfc2396E" href="mailto:weijun.wang@oracle.com"><weijun.wang@oracle.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
On Jul 25, 2014, at 22:30, Sean Mullan <a class="moz-txt-link-rfc2396E" href="mailto:sean.mullan@oracle.com"><sean.mullan@oracle.com></a> wrote:
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap=""><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~weijun/6997010/webrev.00/">http://cr.openjdk.java.net/~weijun/6997010/webrev.00/</a>
4. *IMPORTANT*: In order to easily maintain platform-related entries,
every line (including the last line) in package.access and
package.definition MUST end with ',\' now. A blank line MUST exist
after the last line. This avoid ugly lines like
#ifndef windows entry1. #endif #ifdef windows entry1.,\ entry2
#endif
</pre>
</blockquote>
<pre wrap="">
What happens if someone (inevitably) adds a new package to the list and forgets to do either of these? Does it result in a build failure?
</pre>
</blockquote>
<pre wrap="">
No build failure, but test/java/security/SecurityManager/CheckPackageAccess.java will fail.
I can add check in the build tool.
</pre>
<blockquote type="cite">
<pre wrap="">
Otherwise looks good, although I think it would be useful to write an additional test to make sure the correct providers are installed and ordered correctly on the different platforms, something similar to the java/lang/SecurityManager/CheckPackageAccess.java test but specific to providers.
</pre>
</blockquote>
<pre wrap="">
OK.
Thanks
Max
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>