<div dir="ltr"><div>Really thank you everyone.</div><div><br></div><div>About Warning, sorry my mistake, this warning is from IntelliJ.</div><div>Removed long lines, replace StringBuffer to StringBuilder and I did the optimizations.</div>
<div>About the template in Parser.jjt, TokenMgrError.java, etc. I don't know how can do that. Can anyone help me?</div>
<div>About readable of code I just renamed this class to sb instead of buf, strbuf, etc. Because using StringBuilder beyond be more explicit I can use char instead of a single String.</div><div><br></div><div><a href="https://dl.dropboxusercontent.com/u/16109193/open_jdk/string_builder_concat_3.zip" target="_blank">https://dl.dropboxusercontent.com/u/16109193/open_jdk/string_builder_concat_3.zip</a><br>
</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Aug 11, 2014 at 7:56 AM, Pavel Rappo <span dir="ltr"><<a href="mailto:pavel.rappo@oracle.com" target="_blank">pavel.rappo@oracle.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">> In the class<br>
> src/share/classes/javax/management/openmbean/CompositeType.java you have<br>
> added the<br>
> annotation @SuppressWarnings("StringConcatenationInsideStringBufferAppend")<br>
> instead of fixing the concatenation inside the append method. Why?<br>
<br>
</div>+1 Moreover, I wonder where this value comes from? I've never seen it before. Here are warnings that javac supports:<br>
<br>
all,auxiliaryclass,cast,classfile,deprecation,dep-ann,divzero,empty,fallthrough,finally,options,overloads,overrides,path,processing,rawtypes,serial,static,try,unchecked,varargs<br>
<br>
It doesn't look like one of Eclipse's warnings either.<br>
<div class=""><br>
> And I would like to suggest to drop explicit usage of StringBuilder in some<br>
> methods at all to improve code readability.<br>
<br>
</div>Agree.<br>
<span class="HOEnZb"><font color="#888888"><br>
-Pavel<br>
<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><div><div style="text-align:center"><div><span style="text-align:start">Otávio Gonçalves de Santana</span><div style="text-align:start">
<div style="text-align:center"><br><div style="text-align:left"><font face="Tahoma">blog: </font><a href="http://otaviosantana.blogspot.com.br/" style="text-align:center" target="_blank">http://otaviosantana.blogspot.com.br/</a></div>
<div style="text-align:left">twitter: <a href="http://twitter.com/otaviojava" target="_blank">http://twitter.com/otaviojava</a></div><div style="text-align:left">site: <span style="text-align:center"><font color="#0000ee"><u><a href="http://about.me/otaviojava" target="_blank">http://about.me/otaviojava</a></u></font></span></div>
<div style="text-align:left">55 (11) 98255-3513</div></div></div></div></div></div></div>
</div>