<div dir="ltr"><div>Thank you Andrej</div><div>Done.</div><div><br></div><a href="https://dl.dropboxusercontent.com/u/16109193/open_jdk/string_builder_concat_5.zip">https://dl.dropboxusercontent.com/u/16109193/open_jdk/string_builder_concat_5.zip</a><br>

</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 12, 2014 at 4:48 AM, Andrej Golovnin <span dir="ltr"><<a href="mailto:andrej.golovnin@gmail.com" target="_blank">andrej.golovnin@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi Otávio,</div><div><br></div><div>I think you should fix the indentation in a lot of classes. You use the tab-character for the indentation. As far as I know we should use the space character for the indentation in the JDK sources (Oracle devs feel free to correct me if I'm wrong. And it would be really nice if the style guide for the source code would be a part of the JDK repository. So we don't need to search for it on the internet/wiki. Just clone the repository, read the style guide and follow it. :-) ). Here is the not complete list of classes where you used the tab-character for the indentation:</div>


<div><br></div>src/share/classes/com/sun/crypto/provider/OAEPParameters.java<div>src/share/classes/java/lang/management/MemoryUsage.java</div><div>src/share/classes/java/security/KeyStore.java</div><div>src/share/classes/java/security/PermissionCollection.java<br>


</div><div>src/share/classes/java/security/ProtectionDomain.java<br></div><div>src/share/classes/java/security/cert/CertPath.java<br></div><div>src/share/classes/java/security/cert/PKIXCertPathBuilderResult.java<br></div>


<div>src/share/classes/java/security/cert/PKIXParameters.java<br></div><div>src/share/classes/java/security/cert/PolicyQualifierInfo.java<br></div><div>src/share/classes/java/security/cert/TrustAnchor.java<br></div><div>

src/share/classes/java/security/cert/X509CertSelector.java</div>
<div>src/share/classes/javax/crypto/CryptoPermission.java</div><div>src/share/classes/javax/management/relation/Role.java</div><div><br><div><br></div><div>In src/share/classes/com/sun/jmx/snmp/IPAcl/Parser.jj in the line 423 a dot is missed before append:<br>


</div><div><br></div><div>423   {jjtn000.name.append( '.')append(t.image); }<br></div><div><br></div><div>Best regards,</div></div><div>Andrej Golovnin</div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><div><div style="text-align:center"><div><span style="text-align:start">Otávio Gonçalves de Santana</span><div style="text-align:start"><div style="text-align:center">

<br><div style="text-align:left"><font face="Tahoma">blog:     </font><a href="http://otaviosantana.blogspot.com.br/" style="text-align:center" target="_blank">http://otaviosantana.blogspot.com.br/</a></div><div style="text-align:left">

twitter: <a href="http://twitter.com/otaviojava" target="_blank">http://twitter.com/otaviojava</a></div><div style="text-align:left">site:     <span style="text-align:center"><font color="#0000ee"><u><a href="http://about.me/otaviojava" target="_blank">http://about.me/otaviojava</a></u></font></span></div>

<div style="text-align:left">55 (11) 98255-3513</div></div></div></div></div></div></div>
</div>