<div dir="ltr">Could anyone help me as sponsor, please?<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 12, 2014 at 8:01 PM, Otávio Gonçalves de Santana <span dir="ltr"><<a href="mailto:otaviojava@java.net" target="_blank">otaviojava@java.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Thank you Roger.</div><div>Done</div><a href="https://dl.dropboxusercontent.com/u/16109193/open_jdk/string_builder_concat_6.zip" target="_blank">https://dl.dropboxusercontent.com/u/16109193/open_jdk/string_builder_concat_6.zip</a><br>
</div><div class="gmail_extra"><div><div class="h5"><br><br><div class="gmail_quote">On Tue, Aug 12, 2014 at 10:15 AM, roger riggs <span dir="ltr"><<a href="mailto:roger.riggs@oracle.com" target="_blank">roger.riggs@oracle.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">fyi,<br>
<br>
There's a Perl script <a href="http://normalizer.pl" target="_blank">normalizer.pl</a> that detects/fixes most of the simple tab/white space issues.<br>
The script is in the <repo>/make/scripts/<a href="http://normalizer.pl" target="_blank">normalizer<u></u>.pl</a><span><font color="#888888"><br>
<br>
Roger</font></span><div><div><br>
<br>
On 8/12/2014 3:48 AM, Andrej Golovnin wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Otávio,<br>
<br>
I think you should fix the indentation in a lot of classes. You use the<br>
tab-character for the indentation. As far as I know we should use the space<br>
character for the indentation in the JDK sources (Oracle devs feel free to<br>
correct me if I'm wrong. And it would be really nice if the style guide for<br>
the source code would be a part of the JDK repository. So we don't need to<br>
search for it on the internet/wiki. Just clone the repository, read the<br>
style guide and follow it. :-) ). Here is the not complete list of classes<br>
where you used the tab-character for the indentation:<br>
<br>
src/share/classes/com/sun/<u></u>crypto/provider/<u></u>OAEPParameters.java<br>
src/share/classes/java/lang/<u></u>management/MemoryUsage.java<br>
src/share/classes/java/<u></u>security/KeyStore.java<br>
src/share/classes/java/<u></u>security/PermissionCollection.<u></u>java<br>
src/share/classes/java/<u></u>security/ProtectionDomain.java<br>
src/share/classes/java/<u></u>security/cert/CertPath.java<br>
src/share/classes/java/<u></u>security/cert/<u></u>PKIXCertPathBuilderResult.java<br>
src/share/classes/java/<u></u>security/cert/PKIXParameters.<u></u>java<br>
src/share/classes/java/<u></u>security/cert/<u></u>PolicyQualifierInfo.java<br>
src/share/classes/java/<u></u>security/cert/TrustAnchor.java<br>
src/share/classes/java/<u></u>security/cert/<u></u>X509CertSelector.java<br>
src/share/classes/javax/<u></u>crypto/CryptoPermission.java<br>
src/share/classes/javax/<u></u>management/relation/Role.java<br>
<br>
<br>
In src/share/classes/com/sun/jmx/<u></u>snmp/IPAcl/Parser.jj in the line 423 a dot<br>
is missed before append:<br>
<br>
423 {jjtn000.name.append( '.')append(t.image); }<br>
<br>
Best regards,<br>
Andrej Golovnin<br>
</blockquote>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><div class="">-- <br><div dir="ltr"><div><div style="text-align:center"><div><span style="text-align:start">Otávio Gonçalves de Santana</span><div style="text-align:start">
<div style="text-align:center"><br><div style="text-align:left"><font face="Tahoma">blog: </font><a href="http://otaviosantana.blogspot.com.br/" style="text-align:center" target="_blank">http://otaviosantana.blogspot.com.br/</a></div>
<div style="text-align:left">twitter: <a href="http://twitter.com/otaviojava" target="_blank">http://twitter.com/otaviojava</a></div><div style="text-align:left">site: <span style="text-align:center"><font color="#0000ee"><u><a href="http://about.me/otaviojava" target="_blank">http://about.me/otaviojava</a></u></font></span></div>
<div style="text-align:left"><a href="tel:55%20%2811%29%2098255-3513" value="+5511982553513" target="_blank">55 (11) 98255-3513</a></div></div></div></div></div></div></div>
</div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><div><div style="text-align:center"><div><span style="text-align:start">Otávio Gonçalves de Santana</span><div style="text-align:start"><div style="text-align:center">
<br><div style="text-align:left"><font face="Tahoma">blog: </font><a href="http://otaviosantana.blogspot.com.br/" style="text-align:center" target="_blank">http://otaviosantana.blogspot.com.br/</a></div><div style="text-align:left">
twitter: <a href="http://twitter.com/otaviojava" target="_blank">http://twitter.com/otaviojava</a></div><div style="text-align:left">site: <span style="text-align:center"><font color="#0000ee"><u><a href="http://about.me/otaviojava" target="_blank">http://about.me/otaviojava</a></u></font></span></div>
<div style="text-align:left">55 (11) 98255-3513</div></div></div></div></div></div></div>
</div>