<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Max,<br>
<br>
Thanks for review.<br>
<br>
testDigestOnOff including following two cases.<br>
<ul>
<li>Test digest when set digest function on:</li>
<ul>
<li>Set the digest function on both DigestInputStream and
DigestOutputStream</li>
<li>Perform the update for using all available/possible update
methods, update action including call read() read data from
DigestInputStream then write data to DigestOutputStream.</li>
<li>Compare generated digest values of DigestInputStream and
DigestOutputStream</li>
</ul>
<li>Test digest when turns digest function on and off:</li>
<ul>
<li>Turns the digest function on and off, set same digest
function value for DigestInputStream and DigestOutputStream in
one update cycle.</li>
<li>Perform the update for using all available/possible update
methods</li>
<li>Compare generated digest values of DigestInputStream and
DigestOutputStream</li>
</ul>
</ul>
Please review the comments, if OK I will update this comments into
webrev.<br>
<br>
Thanks again.<br>
<br>
Kevin<br>
<div class="moz-cite-prefix">于 2014/8/18 16:43, Wang Weijun 写道:<br>
</div>
<blockquote
cite="mid:9BC521EA-369C-4D8D-8906-AC5D260414D9@oracle.com"
type="cite">
<pre wrap="">Hi Kevin
I tried to read the new test. TestMDChange and TestMDShare are OK, but I am confused on what testDigestOnOff is doing. Can you add some comments there?
Thanks
Max
On Aug 18, 2014, at 14:35, zaiyao liu <a class="moz-txt-link-rfc2396E" href="mailto:zaiyao.liu@oracle.com"><zaiyao.liu@oracle.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi Brad,
Can you help to review this new test for DigestIOStream?
Thanks
Kevin
于 2014/8/1 11:10, zaiyao liu 写道:
</pre>
<blockquote type="cite">
<pre wrap="">May I request you to review 1 new test to be added for messageDigest with DigestIOStream. New test are added to address following:
- Test DigestInputStream and DigestOutputStream digest function when digest set on and off
- Test DigestInputStream and DigestOutputStream digest function when Swap the message digest engines between DigestIn/OutputStream
- Test DigestInputStream and DigestOutputStream digest function when use same message digest object.
JDK Issue: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8050370">https://bugs.openjdk.java.net/browse/JDK-8050370</a>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~rhalade/8050370/webrev.00/">http://cr.openjdk.java.net/~rhalade/8050370/webrev.00/</a>
Thanks,
Kevin
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>