<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<a href="https://bugs.openjdk.java.net/browse/JDK-8038277" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8038277</a></blockquote><div><br></div><div>This is not the right bug report. The subject of this bug report is "Improve the bootstrap performance of carets keystore".</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
<a href="http://cr.openjdk.java.net/~weijun/8038277/client/webrev.00" target="_blank">http://cr.openjdk.java.net/~weijun/8038277/client/webrev.00</a></blockquote><div><br></div><div>TABs are still used for indentation. I looked only at src/java.desktop/share/classes/javax/swing/RepaintManager.java.</div>
<div><br></div><div>Best regards,</div><div>Andrej Golovnin</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
<a href="http://cr.openjdk.java.net/~weijun/8038277/core/webrev.00/" target="_blank">http://cr.openjdk.java.net/~weijun/8038277/core/webrev.00/</a><br>
<a href="http://cr.openjdk.java.net/~weijun/8038277/extra/webrev.00/" target="_blank">http://cr.openjdk.java.net/~weijun/8038277/extra/webrev.00/</a><br>
<br>
--Max<br>
<div><div class="h5"><br>
On Aug 21, 2014, at 10:32, Otávio Gonçalves de Santana <<a href="mailto:otaviojava@java.net">otaviojava@java.net</a>> wrote:<br>
<br>
> Thank you Wang.<br>
> Actually I haven't neither webrev and bug id.<br>
> I believe is better split in client and server code.<br>
> <a href="https://dl.dropboxusercontent.com/u/16109193/open_jdk/string_builder_concat_8.zip" target="_blank">https://dl.dropboxusercontent.com/u/16109193/open_jdk/string_builder_concat_8.zip</a><br>
><br>
><br>
> On Tue, Aug 19, 2014 at 10:55 PM, Wang Weijun <<a href="mailto:weijun.wang@oracle.com">weijun.wang@oracle.com</a>> wrote:<br>
> Hi Otávio<br>
><br>
> I see TABs in the first page of sun_security.diff, too long line in javax_security.diff.<br>
><br>
> Also, it's unfortunate that you will need to rename the file names to the new style with modules. See <a href="http://cr.openjdk.java.net/~chegar/docs/portingScript.html" target="_blank">http://cr.openjdk.java.net/~chegar/docs/portingScript.html</a> for how to do this.<br>
><br>
> I can create webrev page(s) for you on <a href="http://cr.openjdk.java.net" target="_blank">cr.openjdk.java.net</a>. Please tell me if you want a big one or one for each diff.<br>
><br>
> I see no bug id. If none, I can create one for you.<br>
><br>
> Thanks<br>
> Max<br>
><br>
> On Aug 20, 2014, at 9:05, Otávio Gonçalves de Santana <<a href="mailto:otaviojava@java.net">otaviojava@java.net</a>> wrote:<br>
><br>
> > Thank you Sergey.<br>
> > <a href="https://dl.dropboxusercontent.com/u/16109193/open_jdk/string_builder_concat_7.zip" target="_blank">https://dl.dropboxusercontent.com/u/16109193/open_jdk/string_builder_concat_7.zip</a><br>
> ><br>
> ><br>
> > On Tue, Aug 19, 2014 at 12:32 PM, Sergey Bylokhov <<br>
> > <a href="mailto:Sergey.Bylokhov@oracle.com">Sergey.Bylokhov@oracle.com</a>> wrote:<br>
> ><br>
> >> Hi Otávio,<br>
> >> The new alignment in DataLine.java/JColorChooser.java looks strange.<br>
> >> Wrong change in BasicTableUI.java:<br>
> >> - plainStr.deleteCharAt(plainStr.length() -<br>
> >> 1).append("\n");<br>
> >> + plainStr.deleteCharAt(plainStr.length() -<br>
> >> 1).append('\t');<br>
> >><br>
> >><br>
> >> On 13.08.2014 3:01, Otávio Gonçalves de Santana wrote:<br>
> >><br>
> >>> Thank you Roger.<br>
> >>> Done<br>
> >>> <a href="https://dl.dropboxusercontent.com/u/16109193/open_jdk/" target="_blank">https://dl.dropboxusercontent.com/u/16109193/open_jdk/</a><br>
> >>> string_builder_concat_6.zip<br>
> >>><br>
> >>><br>
> >>> On Tue, Aug 12, 2014 at 10:15 AM, roger riggs <<a href="mailto:roger.riggs@oracle.com">roger.riggs@oracle.com</a>><br>
> >>> wrote:<br>
> >>><br>
> >>> fyi,<br>
> >>>><br>
> >>>> There's a Perl script <a href="http://normalizer.pl" target="_blank">normalizer.pl</a> that detects/fixes most of the<br>
> >>>> simple<br>
> >>>> tab/white space issues.<br>
> >>>> The script is in the <repo>/make/scripts/<a href="http://normalizer.pl" target="_blank">normalizer.pl</a><br>
> >>>><br>
> >>>> Roger<br>
> >>>><br>
> >>>><br>
> >>>> On 8/12/2014 3:48 AM, Andrej Golovnin wrote:<br>
> >>>><br>
> >>>> Hi Otávio,<br>
> >>>>><br>
> >>>>> I think you should fix the indentation in a lot of classes. You use the<br>
> >>>>> tab-character for the indentation. As far as I know we should use the<br>
> >>>>> space<br>
> >>>>> character for the indentation in the JDK sources (Oracle devs feel free<br>
> >>>>> to<br>
> >>>>> correct me if I'm wrong. And it would be really nice if the style guide<br>
> >>>>> for<br>
> >>>>> the source code would be a part of the JDK repository. So we don't need<br>
> >>>>> to<br>
> >>>>> search for it on the internet/wiki. Just clone the repository, read the<br>
> >>>>> style guide and follow it. :-) ). Here is the not complete list of<br>
> >>>>> classes<br>
> >>>>> where you used the tab-character for the indentation:<br>
> >>>>><br>
> >>>>> src/share/classes/com/sun/crypto/provider/OAEPParameters.java<br>
> >>>>> src/share/classes/java/lang/management/MemoryUsage.java<br>
> >>>>> src/share/classes/java/security/KeyStore.java<br>
> >>>>> src/share/classes/java/security/PermissionCollection.java<br>
> >>>>> src/share/classes/java/security/ProtectionDomain.java<br>
> >>>>> src/share/classes/java/security/cert/CertPath.java<br>
> >>>>> src/share/classes/java/security/cert/PKIXCertPathBuilderResult.java<br>
> >>>>> src/share/classes/java/security/cert/PKIXParameters.java<br>
> >>>>> src/share/classes/java/security/cert/PolicyQualifierInfo.java<br>
> >>>>> src/share/classes/java/security/cert/TrustAnchor.java<br>
> >>>>> src/share/classes/java/security/cert/X509CertSelector.java<br>
> >>>>> src/share/classes/javax/crypto/CryptoPermission.java<br>
> >>>>> src/share/classes/javax/management/relation/Role.java<br>
> >>>>><br>
> >>>>><br>
> >>>>> In src/share/classes/com/sun/jmx/snmp/IPAcl/Parser.jj in the line 423 a<br>
> >>>>> dot<br>
> >>>>> is missed before append:<br>
> >>>>><br>
> >>>>> 423 {jjtn000.name.append( '.')append(t.image); }<br>
> >>>>><br>
> >>>>> Best regards,<br>
> >>>>> Andrej Golovnin<br>
> >>>>><br>
> >>>>><br>
> >>>><br>
> >>><br>
> >><br>
> >> --<br>
> >> Best regards, Sergey.<br>
> >><br>
> >><br>
> ><br>
> ><br>
> > --<br>
> > Otávio Gonçalves de Santana<br>
> ><br>
> > blog: <a href="http://otaviosantana.blogspot.com.br/" target="_blank">http://otaviosantana.blogspot.com.br/</a><br>
> > twitter: <a href="http://twitter.com/otaviojava" target="_blank">http://twitter.com/otaviojava</a><br>
> > site: *<a href="http://about.me/otaviojava" target="_blank">http://about.me/otaviojava</a> <<a href="http://about.me/otaviojava" target="_blank">http://about.me/otaviojava</a>>*<br>
> > 55 (11) 98255-3513<br>
> > <sun_tools.diff><sun_security.diff><sun_net.diff><sun_management.diff><sun_launcher.diff><sun_font.diff><javax_swing.diff><javax_sound.diff><javax_security.diff><javax_naming.diff><javax_crypto.diff><javax_,anagement.diff><java_util.diff><java_text.diff><java_security.diff><java_rmi.diff><java_lang.diff><com_sun.diff><br>
><br>
><br>
><br>
><br>
> --<br>
> Otávio Gonçalves de Santana<br>
><br>
> blog: <a href="http://otaviosantana.blogspot.com.br/" target="_blank">http://otaviosantana.blogspot.com.br/</a><br>
> twitter: <a href="http://twitter.com/otaviojava" target="_blank">http://twitter.com/otaviojava</a><br>
</div></div><div class="">> site: <a href="http://about.me/otaviojava" target="_blank">http://about.me/otaviojava</a><br>
> 55 (11) 98255-3513<br>
</div>> <string_concat_updated.patch><br>
<br>
</blockquote></div><br></div></div>