<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Bernd, <br>
Thanks for looking into it. my comments in-line. <br>
<div class="moz-cite-prefix">On 8/27/2014 2:57 PM, Bernd Eckenfels
wrote:<br>
</div>
<blockquote cite="mid:53fda492.d2318c0a.3032.ffff91a5@mx.google.com"
type="cite">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div>
<div style="font-family: Calibri,sans-serif; font-size: 11pt;">Hello,<br>
<br>
Since the topic is interesting to me I took a look. Have some
nits or points to discuss: The testProvider() function seems
to be missnamed, it actually checks the default Implementation
(for the right provider). Maybe testDefaultProvider()?<br>
<br>
</div>
</div>
</blockquote>
Yes you are right . I will rename the testname.<br>
<blockquote cite="mid:53fda492.d2318c0a.3032.ffff91a5@mx.google.com"
type="cite">
<div>
<div style="font-family: Calibri,sans-serif; font-size: 11pt;">
i would also remove the elses, especially as they print
different Passed messages. Just one print line after the
guards.<br>
</div>
</div>
</blockquote>
Agree on this. <br>
<blockquote cite="mid:53fda492.d2318c0a.3032.ffff91a5@mx.google.com"
type="cite">
<div>
<div style="font-family: Calibri,sans-serif; font-size: 11pt;"><br>
BTW, i think it is very common for java code to request
SHA1Prng unconditionally (with and without provider=sun) i
would add that to all OS as a test. <br>
</div>
</div>
</blockquote>
This is already covered by test -
sun/security/provider/SeedGenerator/SeedGeneratorChoice.java <br>
<blockquote cite="mid:53fda492.d2318c0a.3032.ffff91a5@mx.google.com"
type="cite">
<div>
<div style="font-family: Calibri,sans-serif; font-size: 11pt;"><br>
I also wonder if this would be the right place to test the
strong secure random getter as well?<br>
<br>
</div>
</div>
</blockquote>
Those tests are already covered Java Compatibility tests . That is
the reason it is omitted from this test.<br>
<blockquote cite="mid:53fda492.d2318c0a.3032.ffff91a5@mx.google.com"
type="cite">
<div>
<div style="font-family: Calibri,sans-serif; font-size: 11pt;">what
about testing the sorting logic (based on the egd url
property) I think this is still implemented, even with the
different seeding modes for Native.<br>
<br>
</div>
</div>
</blockquote>
This covered by some of the existing tests <br>
sun/security/provider/SecureRandom/StrongSeedReader.java , <br>
test/closed/sun/security/provider/SecureRandom/SeederRace.java<br>
sun/security/provider/SeedGenerator/SeedGeneratorChoice.java<br>
<br>
Thanks,<br>
Raghu<br>
<blockquote cite="mid:53fda492.d2318c0a.3032.ffff91a5@mx.google.com"
type="cite">
<div>
<div style="font-family: Calibri,sans-serif; font-size: 11pt;">Gruss<br>
Bernd<br>
<br>
-- <br>
<a class="moz-txt-link-freetext" href="http://bernd.eckenfels.net">http://bernd.eckenfels.net</a></div>
</div>
<div dir="ltr">
<hr><span style="font-family: Calibri,sans-serif; font-size:
11pt; font-weight: bold;">Von: </span><span
style="font-family: Calibri,sans-serif; font-size: 11pt;"><a
moz-do-not-send="true" href="mailto:raghu.k.nair@oracle.com">raghu
k.nair</a></span><br>
<span style="font-family: Calibri,sans-serif; font-size: 11pt;
font-weight: bold;">Gesendet: </span><span
style="font-family: Calibri,sans-serif; font-size: 11pt;">27.08.2014
11:00</span><br>
<span style="font-family: Calibri,sans-serif; font-size: 11pt;
font-weight: bold;">An: </span><span style="font-family:
Calibri,sans-serif; font-size: 11pt;"><a
moz-do-not-send="true"
href="mailto:bradford.wetmore@oracle.com">Bradford Wetmore</a></span><br>
<span style="font-family: Calibri,sans-serif; font-size: 11pt;
font-weight: bold;">Cc: </span><span style="font-family:
Calibri,sans-serif; font-size: 11pt;"><a
moz-do-not-send="true"
href="mailto:security-dev@openjdk.java.net">security-dev@openjdk.java.net</a></span><br>
<span style="font-family: Calibri,sans-serif; font-size: 11pt;
font-weight: bold;">Betreff: </span><span style="font-family:
Calibri,sans-serif; font-size: 11pt;">Please review CR 8048356
Secure Random provider tests</span><br>
<br>
</div>
Hi Brad, <br>
Could you please help in reviewing the following test. <br>
<br>
webrev: <a
href="http://cr.openjdk.java.net/%7Etyan/raghu/8048356/webrev01/"
moz-do-not-send="true"><font face="Menlo">http://cr.openjdk.java.net/~tyan/raghu/8048356/webrev01/</font></a><br>
<font face="Menlo">Bug : </font><a moz-do-not-send="true"
id="key-val" style="color: rgb(50, 108, 166); text-decoration:
none;" href="https://bugs.openjdk.java.net/browse/JDK-8048356"
rel="4732999">JDK-8048356</a><br>
<br>
Thanks,<br>
Raghu Nair<br>
</blockquote>
<br>
</body>
</html>