<html><head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#ffffff"><div><div style="font-family: Calibri,sans-serif; font-size: 11pt;">Hello,<br><br>Since the topic is interesting to me I took a look. Have some nits or points to discuss: The testProvider() function seems to be missnamed, it actually checks the default Implementation (for the right provider). Maybe testDefaultProvider()?<br><br> i would also remove the elses, especially as they print different Passed messages. Just one print line after the guards.<br><br>BTW, i think it is very common for java code to request SHA1Prng unconditionally (with and without provider=sun) i would add that to all OS as a test. <br><br> I also wonder if this would be the right place to test the strong secure random getter as well?<br><br>what about testing the sorting logic (based on the egd url property) I think this is still implemented, even with the different seeding modes for Native.<br><br>Gruss<br>Bernd<br><br>-- <br>http://bernd.eckenfels.net</div></div><div dir="ltr"><hr><span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">Von: </span><span style="font-family: Calibri,sans-serif; font-size: 11pt;"><a href="mailto:raghu.k.nair@oracle.com">raghu k.nair</a></span><br><span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">Gesendet: </span><span style="font-family: Calibri,sans-serif; font-size: 11pt;">27.08.2014 11:00</span><br><span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">An: </span><span style="font-family: Calibri,sans-serif; font-size: 11pt;"><a href="mailto:bradford.wetmore@oracle.com">Bradford Wetmore</a></span><br><span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">Cc: </span><span style="font-family: Calibri,sans-serif; font-size: 11pt;"><a href="mailto:security-dev@openjdk.java.net">security-dev@openjdk.java.net</a></span><br><span style="font-family: Calibri,sans-serif; font-size: 11pt; font-weight: bold;">Betreff: </span><span style="font-family: Calibri,sans-serif; font-size: 11pt;">Please review CR 8048356 Secure Random provider tests</span><br><br></div>
Hi Brad, <br>
Could you please help in reviewing the following test. <br>
<br>
webrev: <a href="http://cr.openjdk.java.net/%7Etyan/raghu/8048356/webrev01/" moz-do-not-send="true"><font face="Menlo">http://cr.openjdk.java.net/~tyan/raghu/8048356/webrev01/</font></a><br>
<font face="Menlo">Bug : </font><a id="key-val" style="color: rgb(50, 108, 166); text-decoration: none;" href="https://bugs.openjdk.java.net/browse/JDK-8048356" rel="4732999">JDK-8048356</a><br>
<br>
Thanks,<br>
Raghu Nair<br>
</body></html>