<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I should have prefixed my comments with point that this is a request
for review given the changes. Subject updated.<br>
<br>
regards,<br>
Sean.<br>
<br>
<div class="moz-cite-prefix">On 01/10/2014 17:23, Seán Coffey wrote:<br>
</div>
<blockquote cite="mid:542C2A89.2030808@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
Turned out that I do need to make a change to this backport. The
testcase hadn't run initially on JPRT due to a new path in the
test directories. I've fixed that now. The testcase needs tweaking
for 7u.<br>
<br>
For 7u, the TLS_RSA_WITH_AES_128_CBC_SHA256 ciphersuite is not
enabled by default in ClientHello. A minor change to the testcase
on client socket can change that. <br>
<br>
<blockquote type="cite">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"> 137 String[] ciphers = sslSocket.getSupportedCipherSuites();
138 sslSocket.setEnabledCipherSuites(ciphers);</pre>
</blockquote>
<br>
Rest of testcase stays the same as jdk8u.<br>
webrev : <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ecoffeys/webrev.8052406.7u/webrev/">http://cr.openjdk.java.net/~coffeys/webrev.8052406.7u/webrev/</a><br>
<br>
regards,<br>
Sean.<br>
<br>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<div class="moz-forward-container"><br>
<br>
-------- Forwarded Message --------
<table class="moz-email-headers-table" border="0"
cellpadding="0" cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject:
</th>
<td>Re: [7u-dev] Request for approval : 8052406:
SSLv2Hello protocol may be filtered out unexpectedly</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date:
</th>
<td>Tue, 30 Sep 2014 19:06:18 +0100</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">From:
</th>
<td>Rob McKenna <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:rob.mckenna@oracle.com"><rob.mckenna@oracle.com></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
<td><a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:jdk7u-dev@openjdk.java.net">jdk7u-dev@openjdk.java.net</a></td>
</tr>
</tbody>
</table>
<br>
<br>
<pre>Approved.
-Rob
On 30/09/14 18:46, Seán Coffey wrote:
> Looking to backport this change from JDK 8u. JDK 8u changeset applies
> cleanly.
>
> bug report : <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8052406">https://bugs.openjdk.java.net/browse/JDK-8052406</a>
> changeset : <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ddba61b06470">http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ddba61b06470</a>
>
> regards,
> Sean.
>
</pre>
<br>
</div>
<br>
</blockquote>
<br>
</body>
</html>