<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">OK thanks. I had been looking for your name in that list.<div><br></div><div>In addition, changesets require a testcase to verify the fix so I've modified an existing keychain testcase.</div><div>I’ve updated the previous webrev, in place:</div><div><br></div><div> <a href="http://cr.openjdk.java.net/~vinnie/8062264/webrev.00/">http://cr.openjdk.java.net/~vinnie/8062264/webrev.00/</a></div><div><br></div><div><div><br></div><div><br><div><div>On 28 Oct 2014, at 11:12, Florian Bruckner (3kraft) <<a href="mailto:florian.bruckner@3kraft.com">florian.bruckner@3kraft.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta content="text/html; charset=windows-1252" http-equiv="Content-Type">
<div text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Vincent,<br>
<br>
the webrev looks good.<br>
<br>
I have also received confirmation that the OCA was approved -
looking at the address you mentioned, it is listed with the
company name "3kraft IT GmbH & Co KG".<br>
<br>
regards,<br>
<br>
Florian<br>
<br>
On 28.10.14 11:50, Vincent Ryan wrote:<br>
</div>
<blockquote cite="mid:50418EAD-5635-437E-B410-ECD7F52717FB@oracle.com" type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
No problem. I made a slight modification to your fix to replace
the fixed password with a randomly generated one.
<div>Here’s the webrev:</div>
<div> <a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Evinnie/8062264/webrev.00/">http://cr.openjdk.java.net/~vinnie/8062264/webrev.00/</a></div>
<div><br>
</div>
<div>If you’re OK with that then I’ll push your fix along with two
other fixes to KeychainStore.</div>
<div><br>
</div>
<div><br>
</div>
<div>BTW OCA approval is required before your patch can be
integrated and I don’t see your name listed at:</div>
<div><span style="font-family: Menlo; font-size: 11px;"> <a moz-do-not-send="true" href="http://www.oracle.com/technetwork/community/oca-486395.html">http://www.oracle.com/technetwork/community/oca-486395.html</a></span></div>
<div><br>
</div>
<div>Did you receive a confirmation email?</div>
<br>
</blockquote>
<br>
</div>
</blockquote></div><br></div></div></body></html>