<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Max, I only have very nit-picky comments/questions, actually the
same question across 4 files.<br>
<ul>
<li>KerberosKey.java</li>
<ul>
<li>298 and 305: Should the "KerberosKey" words be inside @code
braces?</li>
</ul>
<li>KerberosPrincipal.java</li>
<ul>
<li>195: Same @code question as above with "Principal"</li>
</ul>
<li>KerberosTicket.java</li>
<ul>
<li>722 and 729: Same @code question for "KerberosTicket"</li>
</ul>
<li>KeyTab.java</li>
<ul>
<li>341 and 347: ditto, but for "KeyTab"</li>
</ul>
</ul>
<p>--Jamil<br>
</p>
<br>
<div class="moz-cite-prefix">On 11/17/2014 11:47 PM, Wang Weijun
wrote:<br>
</div>
<blockquote
cite="mid:08183D12-9E96-43EC-9147-9034B0C6E989@oracle.com"
type="cite">
<pre wrap="">Re-request for code review at
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~weijun/8061253/webrev.01/">http://cr.openjdk.java.net/~weijun/8061253/webrev.01/</a>
Most are still spec changes, with only one code change in KerberosTicket.java where KerberosPrincipal.toString() is changed to KerberosPrincipal.getName(). This is also because the spec for getName() is more suitable in this call.
*Jamil*: I usually don't touch copyright years and let RE handle it. You might say this is not a good habit.
Thanks
Max
</pre>
<blockquote type="cite">
<pre wrap="">On Nov 15, 2014, at 08:05, Wang Weijun <a class="moz-txt-link-rfc2396E" href="mailto:weijun.wang@oracle.com"><weijun.wang@oracle.com></a> wrote:
Webrev withdrawn. I'd like to make more changes.
Thanks
Max
</pre>
<blockquote type="cite">
<pre wrap="">On Nov 14, 2014, at 10:38, Wang Weijun <a class="moz-txt-link-rfc2396E" href="mailto:weijun.wang@oracle.com"><weijun.wang@oracle.com></a> wrote:
Hi All
This is a doc change only bug. Fix at
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~weijun/8061253/webrev.00/">http://cr.openjdk.java.net/~weijun/8061253/webrev.00/</a>
Please take a review.
Thanks
Max
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>