<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
<br>
Still looking for a reviewer for this fix... <br>
<br>
Thanks,<br>
Valerie<br>
<br>
On 8/22/2014 1:50 PM, Valerie Peng wrote:
<blockquote cite="mid:53F7AD0D.8050601@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
Ping again. Anyone has time to review?<br>
<br>
The webrev has been updated in place for<br>
1) to reflect the new modular path<br>
2) update of test/ProblemList.txt given the integration of the
failed test (done in a separate bug fix which adds bunch of new
tests).<br>
<br>
The main changes are in CipherCore.java to pass the correct data
size when calling cipher.encrypt/decrypt(...).<br>
Also, updated the various modes implementation so that an
Exception is thrown if data with incorrect length are passed. This
is to make the code more robust.<br>
<br>
Thanks,<br>
Valerie<br>
<br>
On 7/18/2014 4:12 PM, Valerie Peng wrote:
<blockquote cite="mid:53C9A9D8.1060109@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
<br>
Can someone please help reviewing this following fix?<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8049312">https://bugs.openjdk.java.net/browse/JDK-8049312</a><br>
Webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Evaleriep/8049312/webrev.00/">http://cr.openjdk.java.net/~valeriep/8049312/webrev.00/</a><br>
<br>
The must-fix change is in <code></code>
src/share/classes/com/sun/crypto/provider/CipherCore.java which
is to correct the data size calculation based on "unitBytes".
For example, for CFB24, our current impl assumes the given data
will be multiples of 3 bytes. When the given data isn't
multiples of 3, it will continue but then the result is
incorrect.<br>
<br>
To make the code more robust, I think we should explicitly check
and error out when the given data doesn't have the correct size.
Thus, I have added the input-length check to the various mode
implementations. Along the way, I also fixed javadoc typos,
removed redundancies, etc.<br>
<br>
Thanks,<br>
Valerie<br>
<br>
</blockquote>
</blockquote>
</body>
</html>