<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body style="background-color: rgb(255, 255, 255); color: rgb(0, 0,
0);" text="#000000" bgcolor="#FFFFFF">
<br>
<div class="moz-cite-prefix">On 01/01/2015 08:56 PM, Chris Hegarty
wrote:<br>
</div>
<blockquote
cite="mid:83431B89-27FD-4087-B643-5FDF4052D8BF@oracle.com"
type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<div>This looks very nice Peter.</div>
<div><br>
</div>
<div>Just a small comment on the test; it may avoid future
problems if the test use deleteFileWithRetry, from the test
library [1], rather than file.delete().</div>
<div><br>
</div>
-Chris.
<div><br>
</div>
<div>[1] <a moz-do-not-send="true"
href="http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/test/lib/testlibrary/jdk/testlibrary/FileUtils.java">http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/test/lib/testlibrary/jdk/testlibrary/FileUtils.java</a></div>
<div><br>
</div>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
Hi Chris,<br>
<br>
Thanks for pointing me to the FileUtils. It got me thinking that the
test might not be able to delete the file on Windows, since after
return from 2nd call to testCaching(), it might still be open (and
it very probably will be in the webrev.04 test).<br>
<br>
So I "fixed" this. I now treat the unsuccessful deletion as a test
failure as it should only occur if the file is not closed at the end
which it now should be.<br>
<br>
Here's the latest webrev:<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.05/">http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.05/</a><br>
<br>
Regards, Peter<br>
<br>
<br>
<blockquote
cite="mid:83431B89-27FD-4087-B643-5FDF4052D8BF@oracle.com"
type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->
<div>
<div>
<div>
<div>On 1 Jan 2015, at 19:21, Peter Levart <<a
moz-do-not-send="true"
href="mailto:peter.levart@gmail.com">peter.levart@gmail.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<div style="background-color: rgb(255, 255, 255);"
text="#000000" bgcolor="#FFFFFF"> <br>
<div class="moz-cite-prefix">On 12/29/2014 04:51 PM,
Alan Bateman wrote:<br>
</div>
<blockquote cite="mid:54A17899.4060304@oracle.com"
type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]--><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->On
29/12/2014 09:45, Peter Levart wrote: <br>
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]--><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->
<br>
Thanks for looking at this, Alan. <br>
<br>
You're right about File.getCanonicalFile(). It
already checks read permission for a file. The
additional explicit check is superfluous. I have
removed it. <br>
<br>
With explicit check I wanted the API to behave
uniformly regardless of whether the returned stream
is opened by getInputStream() call or an already
opened stream is just returned. getCannonicalFile()
already takes care of it. Here's the updated webrev:
<br>
<br>
<a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eplevart/jdk9-dev/FileInputStreamPool.8047769/webrev.03/">http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.03/</a>
<br>
<!--[if !IE]></DIV><![endif]--><!--[if !IE]></DIV><![endif]--></blockquote>
Updated patch looks good to me. <br>
<br>
-Alan. <br>
<!--[if !IE]></DIV><![endif]--><!--[if !IE]></DIV><![endif]--></blockquote>
<br>
Thanks, Alan.<br>
<br>
Peter<br>
</div>
<!--[if !IE]></DIV><![endif]--></blockquote>
</div>
<br>
</div>
</div>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
</body>
</html>