<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body style="background-color: rgb(255, 255, 255); color: rgb(0, 0,
0);" text="#000000" bgcolor="#FFFFFF">
Hi Brad,<br>
<br>
So I created another webrev (just removed the unneeded import and
left-over
<meta http-equiv="content-type" content="text/html; charset=utf-8">
System.out.println from test):<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.06/">http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.06/</a><br>
<br>
I'll leave it here to rest for a couple of days and if no one
objects, I'll push it to jdk9-dev.<br>
<br>
Thanks everybody for reviews and happy new year!<br>
<br>
Regards, Peter<br>
<br>
<div class="moz-cite-prefix">On 01/02/2015 11:58 PM, Bradford
Wetmore wrote:<br>
</div>
<blockquote cite="mid:54A7228D.4040801@oracle.com" type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->
<br>
On 1/1/2015 12:22 PM, Peter Levart wrote:
<br>
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->Hi
Brad,
<br>
<br>
Here's next webrev which tries to cover all your comments:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.04/">http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.04/</a>
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
I downloaded the webrev.05 (Chris' later followup email) and ran
it through JPRT. The only error was the previously seen -Dseed
which is not your problem.
<br>
<br>
Again, I only ran:
<br>
<br>
jdk_lang, jdk_math, jdk_util, jdk_io, jdk_net, jdk_nio,
<br>
jdk_security*, jdk_rmi, jdk_text, jdk_time, jdk_other,
core_tools.
<br>
<br>
If you need anything else run, let me know.
<br>
<br>
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->Looks
like you have a committer status, will you be pushing
this?
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
I can, yes. As soon as we clear-out the remaining questions,
right?
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
Yes. The comments below are minor and shouldn't need another
review
<br>
cycle.
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
I'm worried about the failure of the test you observed while
running
<br>
from NetBeans. Perhaps a 0.5s wait is sometimes not enough for
<br>
ReferenceHandler thread to process (enqueue) a WeakReference.
Since
<br>
there is already a facility in place to help ReferenceHandler
thread
<br>
instead of wait for it, I used it in new version of the test.
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
BTW, there's now an unnecessary import from
java.lang.AssertionError added in webrev.04.
<br>
<br>
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->TEST
RESULT: Failed. Compilation failed: Compilation failed
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
I changed the test to be self-contained now so one can run it
without
<br>
testlib in classpath.
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
Thanks. It's compiling fine now.
<br>
<br>
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->Two
minor nits? SeedGenerator.java: Lines 507/518
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
Done that too.
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
Thanks.
<br>
<br>
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->Maybe
issue multiple reads to exercise in1 and in2? e.g. 2 bytes of
<br>
in1, 4 bytes of in2, then 2 bytes of in1?
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
The 1st assert makes sure in1 == in2, so there's no point in
invoking
<br>
the same instance via two aliases.
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
True.
<br>
<br>
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->IIRC,
when I ran this under NetBeans last week, the second
testCaching
<br>
didn't clear the WeakReference.
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
This should not happen any more now that the test is helping to
enqueue
<br>
the WeakReferences instead of waiting for ReferenceHandler to
enqueue
<br>
them.
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
Yes, that hit the refQueue.poll().
<br>
<br>
It's always interesting to work with core-libs folks, learn
something new everyday. Mixing Lambdas/try-with.
<br>
<br>
I need a time-machine for your CFV/jdk8 Committer:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-August/002896.html">http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-August/002896.html</a>
<br>
<br>
I vote yes.
<br>
<br>
<blockquote type="cite"><!--[if !IE]><DIV style="border-left: 2px solid #009900; border-right: 2px solid #009900; padding: 0px 15px; margin: 2px 0px;"><![endif]-->The
test can now fail only if System.gc() does not trigger
<br>
WeakReference processing in the VM. Can you give it a try on
your
<br>
NetBeans environment?
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
One last comment. It's now 2015. ;)
<br>
<br>
Brad
<br>
<br>
<!--[if !IE]></DIV><![endif]--></blockquote>
<br>
</body>
</html>