<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
<br>
Updated changes look good.<br>
Thanks,<br>
Valerie<br>
<br>
On 1/12/2015 5:37 PM, zaiyao liu wrote:
<blockquote cite="mid:54B476CB.4020208@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
Thanks Valerie for review. Please check the update: <a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ezailiu/8044193/webrev.04/">http://cr.openjdk.java.net/~zailiu/8044193/webrev.04/</a><br>
<br>
Kevin<br>
<div class="moz-cite-prefix">在 2015/1/13 5:07, Valerie Peng 写道:<br>
</div>
<blockquote cite="mid:54B4377C.4060506@oracle.com" type="cite">
<meta http-equiv="Context-Type" content="text/html; ">
Hi, Kevin,<br>
<br>
Somehow I missed your Dec email, sorry for the late reply...<br>
<br>
I should probably clarify my earlier comments about test
policies.<br>
1) are u sure the testAESWithDefaultProvider.policy is
necessary? I didn't find any add/remove provider calls in
TestAESWithDefaultProviders.java?<br>
2) The RuntimePermission fo "loadLibrary.sunec" in the
testAESWithRemoveAddProvider.policy should not be needed. It
could be due to an earlier bug which has been fixed. Can you
please re-run the test without this permission and see if it's
still necessary to have this granted?<br>
3) The 3 test policies even though for different tests, if they
have the same content, perhaps we can consolidate them into just
1. <br>
<br>
Thanks,<br>
Valerie<br>
<br>
On 1/6/2015 3:39 PM, Rajan Halade wrote:
<blockquote cite="mid:54AC7238.2040005@oracle.com" type="cite">
<div class="moz-forward-container">
<table class="moz-email-headers-table">
<tbody>
<tr>
<th nowrap="nowrap">Subject: </th>
<td>Re: Review request for CR 8044193 Need to add
known answer tests for AES cipher</td>
</tr>
<tr>
<th nowrap="nowrap">Date: </th>
<td>Mon, 22 Dec 2014 11:11:38 +0800</td>
</tr>
<tr>
<th nowrap="nowrap">From: </th>
<td>zaiyao liu <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:zaiyao.liu@oracle.com"><zaiyao.liu@oracle.com></a></td>
</tr>
<tr>
<th nowrap="nowrap">Organization: </th>
<td>Oracle Corporation</td>
</tr>
<tr>
<th nowrap="nowrap">To: </th>
<td><a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:security-dev@openjdk.java.net">security-dev@openjdk.java.net</a></td>
</tr>
</tbody>
</table>
<br>
<br>
<pre>Hi Valeries,
Thanks for review, please check the update:
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Erhalade/8044193/webrev.02/">http://cr.openjdk.java.net/~rhalade/8044193/webrev.02/</a>
Regards.
Kevin
在 2014/8/6 3:00, Valerie Peng 写道:
>
> The tests look fine.
> However, can you please update the test policy files with fine-grained
> permissions for SunJCE provider?
> Please refer to the current <jre>/lib/security/java.policy.
>
> Thanks,
> Valerie
>
> On 7/28/2014 9:36 PM, zaiyao liu wrote:
>> Hello,
>> Please help to review the tests for AES cipher.
>> This tests test AES ciphers with different modes and padding
>> schemes when provider change,are part of tests for bug 8044193(Open
>> part)
>> Bug - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8044193">https://bugs.openjdk.java.net/browse/JDK-8044193</a>
>> webrev- <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Erhalade/8044193/webrev.00/">http://cr.openjdk.java.net/~rhalade/8044193/webrev.00/</a>
>>
>> Thanks
>>
>> Kevin Liu
</pre>
<br>
</div>
<br>
</blockquote>
</blockquote>
<br>
</blockquote>
</body>
</html>