<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Sean,<br>
<br>
FYI, I have asked the build team to review the makefile changes.<br>
<br>
BTW, I changed java.security.Provider file to use @implSpec as Joe
has suggested. In addition, I changed the getArgument() impl in
OracleUcrypto provider + SunPKCS11 provider to only return the value
if the caller has read permission to the file. I feel this is
probably safer as we don't want to reveal the path (potential info
leak) to untrusted callers. If the callers don't have the right
permission, then "" is returned. If you prefer SecurityException be
thrown, please let me know. I will need to update the CCC and the
webrev.<br>
<br>
Thanks,<br>
Valerie<br>
<br>
-------- Original Message --------
<table class="moz-email-headers-table" border="0" cellpadding="0"
cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject: </th>
<td>RFR 7191662: JCE providers should be located via
ServiceLoader</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date: </th>
<td>Wed, 27 May 2015 15:29:27 -0700</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">From: </th>
<td>Valerie Peng <a class="moz-txt-link-rfc2396E" href="mailto:valerie.peng@oracle.com"><valerie.peng@oracle.com></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Organization:
</th>
<td>Oracle Corporation</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
<td><a class="moz-txt-link-abbreviated" href="mailto:build-dev@openjdk.java.net">build-dev@openjdk.java.net</a>, Mandy Chung
<a class="moz-txt-link-rfc2396E" href="mailto:mandy.chung@oracle.com"><mandy.chung@oracle.com></a></td>
</tr>
</tbody>
</table>
<br>
<br>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
Hi, build experts,<br>
<br>
Can you please review the make file related change, i.e. the new
file <code></code> <font color="green"><b>make/gensrc/Gensrc-java.naming.gmk</b><font
color="#000000">, in the following webrev:<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Evaleriep/7191662/webrev.01/">http://cr.openjdk.java.net/~valeriep/7191662/webrev.01/</a><br>
<br>
This is for merging the java.security.Provider file from various
providers and use the (merged) result for the final image build.<br>
<br>
The rest of source code changes are reviewed by my team already.<br>
Thanks,<br>
Valerie<br>
(Java Security Team)<br>
</font></font> <br>
</body>
</html>