<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.5pt;
font-family:Consolas;
color:black;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
color:black;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:Consolas;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
color:black;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='color:#1F497D'>Hi, Valerie.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Sorry for the delayed response. <o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Thanks for reviewing. The original webrev was based off of verona/stage which was synch’d to jdk9-b70. The file you reference wasn’t in the repository yet.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Since that time, verona/stage has been sync’d with jdk9-b72 . Here’s the new changeset:<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><a href="http://cr.openjdk.java.net/~iris/verona/8130696/webrev">http://cr.openjdk.java.net/~iris/verona/8130696/webrev</a>.1<o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>In addition to modifying com.sun.security.sasl.gsskerb.JdkSASL, I also updated the S11N.java test to address Sean’s concern. Other security updates pulled in by the sync made some of my copyright updates unnecessary, so those have been removed as well.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Let me know if you have any additional concerns.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Regards.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>iris<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'> Valerie Peng <br><b>Sent:</b> Wednesday, July 08, 2015 7:24 PM<br><b>To:</b> <a href="mailto:security-dev@openjdk.java.net">security-dev@openjdk.java.net</a><br><b>Subject:</b> Re: RFR: (s) 8130696: Security Providers need to have their version numbers updated for JDK 9<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><br>Is the Verona repo sync'ed to the latest OpenJDK? <br>The webrev seems to be missing the provider JdkSASL inside the following file<br>src/jdk.security.jgss/share/classes/com/sun/security/sasl/gsskerb/JdkSASL.java<br><br>The rest looks good.<br>Valerie<br>On 7/7/2015 10:48 AM, Iris Clark wrote: <o:p></o:p></p><p class=MsoPlainText>Hi.<o:p></o:p></p><p class=MsoPlainText> <o:p></o:p></p><p class=MsoPlainText>Please review changes to resolve the following bug:<o:p></o:p></p><p class=MsoPlainText> <o:p></o:p></p><p class=MsoPlainText>8130696: Security Providers need to have their version numbers updated for JDK 9 (Verona)<o:p></o:p></p><p class=MsoPlainText>Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8130696">https://bugs.openjdk.java.net/browse/JDK-8130696</a><o:p></o:p></p><p class=MsoPlainText> <o:p></o:p></p><p class=MsoPlainText>Changeset: <a href="http://cr.openjdk.java.net/~iris/verona/8130696/webrev">http://cr.openjdk.java.net/~iris/verona/8130696/webrev</a><o:p></o:p></p><p class=MsoPlainText> <o:p></o:p></p><p class=MsoPlainText>The constructor invocation for every Provider implementation contains a hard-coded value for the version, "1.9d", which it compares to java.specification.version. Verona [0,1] changes the system property from "1.9" to "9". The provider’s version should be changed to “9.0d”. <o:p></o:p></p><p class=MsoPlainText> <o:p></o:p></p><p class=MsoPlainText>Many regression tests in the jdk repository fail due to this bug. Test groups with failing tests detecting this problem include jdk_security, jdk_management, jdk_jmx, and jdk_net. These tests now pass. I have verified that all providers modified by 8030823 [2] have been updated.<o:p></o:p></p><p class=MsoPlainText> <o:p></o:p></p><p class=MsoPlainText>After review, the changeset will be pushed to verona/stage [3]. The changeset will go to jdk9/dev when Verona is complete later this summer.<o:p></o:p></p><p class=MsoPlainText> <o:p></o:p></p><p class=MsoPlainText>Thanks,<o:p></o:p></p><p class=MsoPlainText>Iris<o:p></o:p></p><p class=MsoPlainText> <o:p></o:p></p><p class=MsoPlainText>[0] <a href="http://openjdk.java.net/projects/verona">http://openjdk.java.net/projects/verona</a><o:p></o:p></p><p class=MsoPlainText>[1] <a href="http://openjdk.java.net/jeps/223">http://openjdk.java.net/jeps/223</a><o:p></o:p></p><p class=MsoPlainText>[2] <a href="http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f1066af06fa0">http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f1066af06fa0</a><o:p></o:p></p><p class=MsoPlainText>[3] <a href="http://hg.openjdk.java.net/verona/stage">http://hg.openjdk.java.net/verona/stage</a><o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p></div></body></html>