<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Sean,<br>
<br>
<div class="moz-cite-prefix">On 8/26/15 8:39 AM, Sean Mullan wrote:<br>
</div>
<blockquote cite="mid:55DDDDC0.5070409@oracle.com" type="cite">This
looks ok now, although I would probably eliminate the tests for
SHA-1 and bump up the keysize to 2048, so that this test won't
have to be updated when those algorithms/keysizes are constrained
in the future.
<br>
</blockquote>
I would take up other enhancements later. For now, I have updated
test to reset jdk.tls.disabledAlgorithms to remove constraints.<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~rhalade/8049237/webrev.02">http://cr.openjdk.java.net/~rhalade/8049237/webrev.02</a><br>
<br>
Thanks,<br>
Rajan<br>
<meta charset="utf-8">
<blockquote cite="mid:55DDDDC0.5070409@oracle.com" type="cite">
<br>
--Sean
<br>
<br>
On 08/25/2015 02:30 PM, Rajan Halade wrote:
<br>
<blockquote type="cite">
<br>
<br>
On 8/25/15 10:09 AM, Sean Mullan wrote:
<br>
<blockquote type="cite">On 08/18/2015 09:01 PM, Xuelei Fan
wrote:
<br>
<blockquote type="cite">Hi Rajan,
<br>
<br>
Sorry for the delay. The code looks fine to me. I was just
wondering,
<br>
what's the purpose for the V1toV3Cert.java test? Is it
practice
<br>
behavior?
<br>
</blockquote>
<br>
I had the same question. I would remove this test as it seems
like a
<br>
obscure case not supported by any of our tools/APIs.
<br>
</blockquote>
This test tries to convert V1 to V3 certificate. Ok, I removed
this test
<br>
case.
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~rhalade/8049237/webrev.01/">http://cr.openjdk.java.net/~rhalade/8049237/webrev.01/</a>
<br>
<br>
Thanks,
<br>
Rajan
<br>
<blockquote type="cite">
<br>
--Sean
<br>
<br>
<blockquote type="cite">Thanks,
<br>
Xuelei
<br>
<br>
On 7/15/2015 9:37 AM, Rajan Halade wrote:
<br>
<blockquote type="cite">May I request you to review two new
tests added. V1toV3Cert tries to
<br>
covert a existing V1 certificate to V3 and V3Certificate
test tries to
<br>
generate V3 certificate with different extensions.
<br>
<br>
Webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~rhalade/8049237/webrev.00/">http://cr.openjdk.java.net/~rhalade/8049237/webrev.00/</a>
<br>
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8049237">https://bugs.openjdk.java.net/browse/JDK-8049237</a>
<br>
<br>
Thanks,
<br>
Rajan
<br>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</body>
</html>