<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><font face="Menlo" class="">Hi Valerie</font><div class=""><font face="Menlo" class=""><br class=""></font></div><div class=""><font face="Menlo" class="">Thank you for reviewing this, I fixed 2 points in latest webrev. Do you mind sponsor this for me if you’re OK with this version.</font></div><div class=""><a href="http://cr.openjdk.java.net/~tyan/8044199/webrev.03/" class=""><font face="Menlo" class="">http://cr.openjdk.java.net/~tyan/8044199/webrev.03/</font></a></div><div class=""><font face="Menlo" class="">Cheers.</font></div><div class=""><font face="Menlo" class="">Tristan</font></div><div class=""><font face="Menlo" class=""><br class=""></font><div class=""><div class=""><div class=""><blockquote type="cite" class=""><div class=""><font face="Menlo" class="">On Aug 28, 2015, at 2:03 PM, Valerie Peng <<a href="mailto:valerie.peng@oracle.com" class="">valerie.peng@oracle.com</a>> wrote:</font></div><font face="Menlo" class=""><br class="Apple-interchange-newline"></font><div class="">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class=""><font face="Menlo" class="">
Hi Tristan,<br class="">
<br class="">
Mostly fine, just 2 more nits:<br class="">
1) KeySizeTest: the @test and @bug are still on the same line.<br class="">
2) SpecTest.java: the @run command from line 40 - 45 still have the
old name, e.g. KeyModulusTest? I think u need to match them.<br class="">
<br class="">
Thanks,<br class="">
Valerie<br class="">
On 8/20/2015 9:31 AM, Tristan Yan wrote:
</font><blockquote cite="mid:55D600E9.4040003@oracle.com" type="cite" class="">
<meta http-equiv="content-type" content="text/html; charset=UTF-8" class="">
<pre class=""><font face="Menlo" class="">Thanks Valerie
Please review the fixed version.
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Etyan/8044199/webrev.02/">http://cr.openjdk.java.net/~tyan/8044199/webrev.02/</a>
Tristan
> Tristan,
>
> - Given that the tests are against SunRsaSign provider, I think
> sun/security/rsa subdirectory is a better choice than java/security/rsa.
> - Put @test and @bug on separate lines
> - Elaborate more on what is tested and what is the expected result in
> the bug record. The current content isn't very clear.
> - Can u have more unique names for these tests? Currently, they are too
> similarly named and it's somewhat confusing. The directory already
> contains RSA, I don't feel that u need to have RSA again in the names of
> the test especially when SunRsaSign provider doesn't support non-RSA
> algorithms.
>
> For KeyTest.java
> 1) typo on line 69, rsaPrivateKey2 should be rsaPrivateKey
> 2) This test is based on the>
provider specific behavior that CRT key is
> generated by default for RSA. It'd be much clearer if you can add an
> instanceof check on the generated RSA private key objects before the
> KeyFactory + RSAPrivateKeySpec code. In addition, add additional code to
> check for equality with the matching KeySpec (e.g. RSAPrivateCrtKeySpec
> for RSAPrivateCrtKey) is used.
> 3) line 58, add a space between '//" and text.
>
> For RSAKeySizeTest.java
> 1) specify provider "SunRSASign" for all getInstance() calls.
> 2) line 55 can be moved up to before the for-loop.
> 3) instead of using toString(int), probably bitLength() would be a
> better choice.
> 4) sizeTest() doesn't really check size but rather it compares the
> modulus values being equal. This check can be moved to RSAKeySizeTest.java.
>
> For RSATest.java
> 1) specify provider "SunRSASign" for all getInstance() calls.
>
> Thanks,
> Valerie
>
> On 8/3/2015 10:27 AM, Tristan Yan wrote:
>><i class=""> Hi
</i>>><i class="">
</i>>><i class=""> Please review new tests for RSA keys and key specifications
</i>>><i class="">
</i>>><i class=""> Bug:<a moz-do-not-send="true" href="https://bugs.openjdk.java.net/browse/JDK-8044199" class="">https://bugs.openjdk.java.net/browse/JDK-8044199</a>
</i>>><i class=""> Webrev:<a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Etyan/8044199/webrev.01/" class="">http://cr.openjdk.java.net/~tyan/8044199/webrev.01/</a> <<a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Etyan/8044199/webrev.01/" class="">http://cr.openjdk.java.net/%7Etyan/8044199/webrev.01/</a>> <<a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Etyan/8044199/webrev.01/" class="">http://cr.openjdk.java.net/~tyan/8044199/webrev.01/</a> <<a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Etyan/8044199/webrev.01/" class="">http://cr.openjdk.java.net/%7Etyan/8044199/webrev.01/</a>>>
</i>>><i class="">
</i>>><i class=""> Thanks
</i>>><i class=""> Tristan
</i>>></font></pre>
</blockquote>
</div>
</div></blockquote></div><br class=""></div></div></div></body></html>