<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Your fix looks fine to me.<div class="">Thanks.</div><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 12 Sep 2015, at 10:23, Wang Weijun <<a href="mailto:weijun.wang@oracle.com" class="">weijun.wang@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Please take a look at<div class=""><br class=""></div><div class=""> <a href="http://cr.openjdk.java.net/~weijun/8136425/webrev.00/" class="">http://cr.openjdk.java.net/~weijun/8136425/webrev.00/</a></div><div class=""><br class=""></div><div class="">It looks like a wrong type is used, kSecFormatX509Cert and kSecFormatWrappedPKCS8 are of SecExternalFormat and the SecKeychainItemImport function also uses this type for its 3rd argument. Constants and function are all defined in</div><div class=""><br class=""></div><div class=""> <a href="http://www.opensource.apple.com/source/libsecurity_keychain/libsecurity_keychain-40768/lib/SecImportExport.h" class="">http://www.opensource.apple.com/source/libsecurity_keychain/libsecurity_keychain-40768/lib/SecImportExport.h</a></div><div class=""><br class=""></div><div class="">It is an enum, so still works.</div><div class=""><br class=""></div><div class="">Thanks</div><div class="">Max</div><div class=""><br class=""></div></div></div></blockquote></div><br class=""></div></body></html>