<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi, Sean,<br>
<br>
Thanks for the comments, I have changed to use the <> for line
110.<br>
For line 116-118, the difference is in the security check. With the
current changes, the new provider will need to be granted <code>SecurityPermission("authProvider.name")</code>
for the configuration call to complete and return the new provider.<br>
<br>
Or, one alternative is to not carrying over the callback handler if
the particular permission is not granted for the new provider?<br>
Not sure if direct assignment/carryover would lead to anything bad,
maybe I am being too paranoid...<br>
<br>
Thanks,<br>
Valerie<br>
<br>
<br>
On 9/22/2015 1:41 PM, Sean Mullan wrote:
<blockquote cite="mid:5601BCEA.5060204@oracle.com" type="cite">On
09/18/2015 08:37 PM, Valerie Peng wrote:
<br>
<blockquote type="cite">Sean,
<br>
<br>
I have updated the webrev based on your suggestions and CCC has
also
<br>
been filed:
<br>
<br>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~valeriep/8130648/webrev.00/">http://cr.openjdk.java.net/~valeriep/8130648/webrev.00/</a>
<br>
</blockquote>
<br>
SunPKCS11.java
<br>
<br>
110: can use diamond operator for anon classes now, ex:
PrivilegedExceptionAction<>
<br>
</blockquote>
<br>
<blockquote cite="mid:5601BCEA.5060204@oracle.com" type="cite">
<br>
116-118: wouldn't it be easier to do the following:
<br>
<br>
116 if (this.pHandler != null) {
<br>
117 newOne.pHandler = this.pHandler;
<br>
118 }
<br>
<br>
then you don't need the catch block on lines 124-128.
<br>
<br>
--Sean
<br>
<br>
<br>
</blockquote>
</body>
</html>