<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Max,<br>
<br>
Please check the updated webrev which address your comments, please
let me know if you have any other suggestions.<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~amjiang/8048357/webrev.02/">http://cr.openjdk.java.net/~amjiang/8048357/webrev.02/</a><br>
<br>
Thanks,<br>
Amanda<br>
<br>
<div class="moz-cite-prefix">On 15/8/21 上午12:13, Weijun Wang wrote:<br>
</div>
<blockquote cite="mid:55D6CF87.807@oracle.com" type="cite">PKCS10AttrOrder.java:
<br>
<br>
- Why not inline revAttributes(), prov() and constructMap()? They
are only used once. Putting the content into the main method is
more clear.
<br>
<br>
- You can create separate method for the while look checks. The 2
look identical.
<br>
<br>
PKCS10AttributeReader.java:
<br>
<br>
- Is it OK to indent the data in the comment to multiple levels?
<br>
<br>
- Again, initMap() not necessary.
<br>
<br>
PKCS7VerifyTest.java:
<br>
<br>
- Not sure what this is for. The 1st and 2nd argument of the @run
line are the same?
<br>
</blockquote>
those 3 arguments are actually for two different test cases, I use
two @run tags in updated webrev and add some comments in test to
make it clear.<br>
<blockquote cite="mid:55D6CF87.807@oracle.com" type="cite">
<br>
SignerOrder.java:
<br>
<br>
- Comment on what derString1 and derString1 are.
<br>
</blockquote>
<blockquote cite="mid:55D6CF87.807@oracle.com" type="cite">
<br>
- What do you expect verifs1.length and verifs2.length to be? Will
you also check it?
<br>
</blockquote>
Yes I do check verifs1.length and verifs2.length should be same.<br>
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: 1; word-spacing: 0px; -webkit-text-stroke-width: 0px;"> 121 if (verifs1.length != verifs2.length) {
122 throw new RuntimeException("Length or Original vs read-in "
123 + "should be same");
124 }</pre>
<br>
<meta charset="utf-8">
<br>
<blockquote cite="mid:55D6CF87.807@oracle.com" type="cite">
<br>
PKCS8Test.java:
<br>
<br>
- Typo: s/recieved/received/g
<br>
<br>
Thanks
<br>
Max
<br>
<br>
On 08/21/2015 07:11 AM, Amanda Jiang wrote:
<br>
<blockquote type="cite">Hi All,
<br>
<br>
Please be free to review new tests for conformance testing of
PKCS.
<br>
<br>
bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8048357">https://bugs.openjdk.java.net/browse/JDK-8048357</a>
<br>
webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~amjiang/8048357/webrev.01/">http://cr.openjdk.java.net/~amjiang/8048357/webrev.01/</a>
<br>
<br>
Thanks,
<br>
Amanda
<br>
<br>
</blockquote>
</blockquote>
<br>
</body>
</html>