<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thanks for the review.<div class=""><br class=""></div><div class="">I’ve incorporated your comments and Xuelei’s comments in a revised webrev:<div class=""> <a href="http://cr.openjdk.java.net/~vinnie/8144093/webrev.01/" class="">http://cr.openjdk.java.net/~vinnie/8144093/webrev.01/</a></div><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 30 Nov 2015, at 21:10, Sean Mullan <<a href="mailto:sean.mullan@oracle.com" class="">sean.mullan@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">SSLParameters.java<br class=""><br class="">649 applicationProtocols = protocols.clone();<br class=""><br class="">You should clone the parameters before checking if they are valid. Move this to line 642, and check the validity of the cloned array. Also, use a temporary variable for the clone, so as not to pollute the applicationProtocols field until you confirm the values are valid, and then assign it to applicationProtocols.<br class=""><br class="">ExtensionType.java<br class=""><br class="">47 new ArrayList<ExtensionType>(15);<br class=""><br class="">nit - you can use diamond operator above<br class=""><br class="">--Sean<br class=""><br class="">On 11/29/2015 07:08 PM, Vincent Ryan wrote:<br class=""><blockquote type="cite" class="">Hello,<br class=""><br class="">Following on from Brad’s recent email, here is the full webrev of the<br class="">API and the implementation classes for ALPN:<br class=""><a href="http://cr.openjdk.java.net/~vinnie/8144093/webrev.00/" class="">http://cr.openjdk.java.net/~vinnie/8144093/webrev.00/</a><br class=""><br class="">In adds the implementation classes (sun/security/ssl) to the public API<br class="">classes (javax/net/ssl) which have already been agreed.<br class="">Some basic tests (test/javax/net/ssl) are also included.<br class=""><br class="">Please send any code review comments by close-of-business on Tuesday 1<br class="">December.<br class="">Thanks.<br class=""></blockquote></div></blockquote></div><br class=""></div></div></body></html>