<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Looks ok to me Xuelei - tricky one to test, we should ensure some
3rd party interoperability testing is run.<br>
Would it make sense to append to the exception message to the debug
message on line 135 ? i.e. <br>
<blockquote type="cite">
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: 1; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(238, 238, 238);"><span class="new" style="color: blue; font-weight: bold;"> 132 if (debug != null && Debug.isOn("handshake")) {</span>
<span class="new" style="color: blue; font-weight: bold;"> 133 System.out.println("The Cipher provider " +</span>
<span class="new" style="color: blue; font-weight: bold;"> 134 cipher.getProvider().getName() +</span>
<span class="new" style="color: blue; font-weight: bold;"> 135 " caused exception : " + iue.getMessage());</span>
<span class="new" style="color: blue; font-weight: bold;"> 136 }</span></pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">Regards,
Sean.</pre>
<div class="moz-cite-prefix">On 15/03/2016 10:34, Xuelei Fan wrote:<br>
</div>
<blockquote cite="mid:56E7E53D.5010702@oracle.com" type="cite">
<pre wrap="">On 3/15/2016 6:29 PM, Bernd Eckenfels wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
BTW, the System.out is already in the existing code, but I wonder if
this should use Debug.println instead?
</pre>
</blockquote>
<pre wrap="">Better to use Debug.println(). I will make the update in an separate
debug log improvement enhancement.
Thanks,
Xuelei
</pre>
<blockquote type="cite">
<pre wrap="">
Gruss
Bernd
--
<a class="moz-txt-link-freetext" href="http://bernd.eckenfels.net">http://bernd.eckenfels.net</a>
*Von: *Xuelei Fan <a class="moz-txt-link-rfc2396E" href="mailto:xuelei.fan@oracle.com"><mailto:xuelei.fan@oracle.com></a>
*Gesendet: *Dienstag, 15. März 2016 11:02
*An: *OpenJDK <a class="moz-txt-link-rfc2396E" href="mailto:security-dev@openjdk.java.net"><mailto:security-dev@openjdk.java.net></a>
*Betreff: *Re: Code Review Request 8149017 Delayed provider selection
broken inRSA client key exchange
Ping ...
On 3/10/2016 11:50 PM, Xuelei Fan wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi,
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">Please review this update:
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap=""> <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~xuelei/8149017/webrev.00/">http://cr.openjdk.java.net/~xuelei/8149017/webrev.00/</a>
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">The problem is that calling Cipher.getProvider, or any method on Cipher,
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">forces the Cipher instance to skip the delayed provider selection which
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">is built into Cipher.
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">In this update, Cipher.init() was changed to be the first call to an
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">instance of Cipher.
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">Thanks,
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">Xuelei
</pre>
</blockquote>
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>