<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hello,<br>
<br>
I would be grateful if someone could find time to review this.<br>
I received few off-line notes and decided to rework this backport a
little.<br>
<br>
Here is my new webrev:<br>
<a
href="http://cr.openjdk.java.net/%7Esnikandrova/8049171/webrev.01/">http://cr.openjdk.java.net/~snikandrova/8049171/webrev.01/</a><br>
<br>
List of current changes from original patch:<br>
1) No ProcessTools.java changes in webrev as they have been
backported earlier.
<br>
2) Utils.java : new utility method <span class="new">transferBetweenStreams</span>
meant to be used instead of InputStream's transferTo method that is
present since 9.
<br>
3)
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
JarUtils.java: changes in createJar method to consider a situation
then files aren't located in current directory.<br>
4) NestedActions.java: refactored to use JarUtils method to create
jars.<br>
5) TimestampCheck.java - omitted
System.getProperty("test.tool.vm.opts") that is not used in jdk 8
testing.
<br>
6) Used System.getProperty("test.jdk") instead of
System.getProperty("java.home")
in tests.<br>
<br>
Thank you,
<br>
Svetlana
<br>
<br>
<div class="moz-cite-prefix">On 28.04.2016 20:35, Svetlana
Nikandrova wrote:<br>
</div>
<blockquote cite="mid:572249EB.8090808@oracle.com" type="cite">Hello,
<br>
<br>
please review and approve the backport of tests enhancement:
<br>
Original tests from
<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8049171">https://bugs.openjdk.java.net/browse/JDK-8049171</a>
<br>
jdk 9 review:
<a class="moz-txt-link-freetext" href="http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-January/031006.html">http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-January/031006.html</a><br>
jdk 9 changeset:
<a class="moz-txt-link-freetext" href="http://hg.openjdk.java.net/jdk9/dev/jdk/rev/5c61ccd9c162">http://hg.openjdk.java.net/jdk9/dev/jdk/rev/5c61ccd9c162</a>
<br>
Originally reviewed by Max Wang
<br>
<br>
Webrev:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~snikandrova/8049171/webrev.00/">http://cr.openjdk.java.net/~snikandrova/8049171/webrev.00/</a>
<a class="moz-txt-link-rfc2396E" href="http://cr.openjdk.java.net/%7Esnikandrova/8049171/webrev.00/"><http://cr.openjdk.java.net/%7Esnikandrova/8049171/webrev.00/></a>
<br>
<br>
List of changes between original patch and current webrev:
<br>
<br>
1) No ProcessTools.java changes as they have been backported
earlier.
<br>
2) JarUtils.java : private method transferToOutputStream instead
ofInputStream's transferTo method (present since 9).
<br>
3) TimestampCheck.java - changes applied by hand to omit
System.getProperty("test.tool.vm.opts") that is not used in jdk 8
testing
<br>
4) Used System.getProperty("test.jdk") instead of
System.getProperty("java.home")
<br>
<br>
Tested with JPRT.
<br>
<br>
Thank you,
<br>
Svetlana
<br>
</blockquote>
<br>
</body>
</html>