<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Thanks Xuelei, thanks Seán!</p>
<p>With kind regards,<br>
Ivan<br>
</p>
<br>
<div class="moz-cite-prefix">On 30.05.2016 19:06, Seán Coffey wrote:<br>
</div>
<blockquote cite="mid:574C64FC.3070205@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
Looks good Ivan. Given that we know that the cipher transformation
is RSA/ECB/PKCS1Padding, maybe you can consider printing that in
the exception. As a result, maybe something like : <br>
<br>
+ System.out.println("Retrieval of
RSA/ECB/PKCS1Padding cipher transformation" +<br>
+ " provider caused exception " +
e.getMessage());<br>
<br>
The cipher.toString() call might be unnecessary as a result then.
Will leave that up to you/Xuelei.<br>
<br>
You might want to consider marking the bug public.<br>
<pre class="moz-signature" cols="72">Regards,
Sean.</pre>
<div class="moz-cite-prefix">On 30/05/16 10:14, Xuelei Fan wrote:<br>
</div>
<blockquote
cite="mid:a98ed45d-be00-e50f-2a8a-1037a6accdc9@oracle.com"
type="cite">
<pre wrap="">Looks fine to me. Thanks!
Xuelei
On 5/30/2016 4:48 PM, Ivan Gerasimov wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hello!
In the file
src/java.base/share/classes/sun/security/ssl/RSAClientKeyExchange.java:
When doing the debug printing:
System.out.println("The Cipher provider " +
cipher.getProvider().getName() +
" caused exception: " + iue.getMessage());
cipher.getProvider() may throw an exception, which will cause the
fail-over branch get skipped.
Furthermore, in the fail-over branch it is better to re-acquire an
instance of the cipher, as the previous call to init() might have left
the current instance in inconsistent state.
Would you please help review the proposed fix?
BUGURL: <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8158111">https://bugs.openjdk.java.net/browse/JDK-8158111</a>
WEBREV: <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Eigerasim/8158111/00/webrev/">http://cr.openjdk.java.net/~igerasim/8158111/00/webrev/</a>
With kind regards,
Ivan
</pre>
</blockquote>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>