<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head><body><div>Oops, good catch. I'll fix that. I assume you don't need a third review for that?</div><div><br></div><div><br></div><div><br></div><div id="composer_signature"><meta http-equiv="Content-Type" content="text/html; charset=UTF-8">--Jamil</div><div><br></div><div style="font-size:100%;color:#000000"><!-- originalMessage --><div>-------- Original message --------</div><div>From: Wang Weijun <weijun.wang@oracle.com> </div><div>Date: 11/15/16 7:48 PM (GMT-08:00) </div><div>To: Jamil Nimeh <jamil.j.nimeh@oracle.com> </div><div>Cc: security-dev@openjdk.java.net </div><div>Subject: Re: RFR 8043252: Debug of access control is obfuscated - NullPointerException in ProtectionDomain </div><div><br></div></div>Looks fine.<br><br>Small nit: new test has copyright 2003, 2016.<br><br>--Max<br><br>> On Nov 16, 2016, at 11:45 AM, Jamil Nimeh <jamil.j.nimeh@oracle.com> wrote:<br>> <br>> Good suggestions, thanks.<br>> <br>> Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8043252/webrev.02<br>> <br>> --Jamil<br>> <br>> <br>> On 11/15/2016 06:18 PM, Wang Weijun wrote:<br>>> 41 System.setSecurityManager(new SecurityManager());<br>>> <br>>> This is strange. I suppose you only want to trigger a permission check?<br>>> <br>>> If so, just change it to Policy.getPolicy(), and you can clean up the policy file a little.<br>>> <br>>> Thanks<br>>> Max<br>>> <br>>>> On Nov 16, 2016, at 8:36 AM, Jamil Nimeh <jamil.j.nimeh@oracle.com> wrote:<br>>>> <br>>>> Hello all,<br>>>> <br>>>> This fixes an issue in ProtectionDomain, where Permission classes that take a loose interpretation of the getActions() method and return null cause an NPE to be thrown when a ProtectionDomain's toString method is called (during debugging for instance).<br>>>> <br>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8043252<br>>>> Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8043252/webrev.01/<br>>>> <br>>>> Thanks,<br>>>> --Jamil<br>> <br><br></body></html>