<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
In the recent jdk8u-dev edits of this file for <span style="color: rgb(0, 0, 0); font-family: monospace; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 15px; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; widows: 1; word-spacing: 0px; -webkit-text-stroke-width: 0px; display: inline !important; float: none; background-color: rgb(255, 255, 255);"></span>8157561,
we introduced a debug field based on this key : <br>
<br>
Debug.getInstance("jca", "Cipher");<br>
<br>
Can we continue to use 'jca' to be consistent for people upgrading ?
<br>
<br>
for the testcase, I guess you can edit
test/javax/crypto/CryptoPermission/TestUnlimited.java but you'll
have to launch with a customized java.security file which doesn't
have crypto.policy set. (Security.setProperty doesn't allow null
values)
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<pre class="moz-signature" cols="72">Regards,
Sean.</pre>
<div class="moz-cite-prefix">On 16/11/16 00:40, Bradford Wetmore
wrote:<br>
</div>
<blockquote
cite="mid:d3562a69-2791-d7a3-e3d4-995db9c75df0@oracle.com"
type="cite">Never noticed that before! We have NOT been
consistent in whether we use:
<br>
<br>
System.out.println()
<br>
or
<br>
debug.println()
<br>
<br>
I knew SeanC wants to rework the JCA/JCE/Security debugging output
in another project, so I will remove the prefix for now. Thanks
for catching it.
<br>
<br>
I will also add a simple regression Test before I push. In
hindsight, it's not as trivial a change as I initially thought.
If you want to review it, I can wait until you are back tomorrow.
<br>
<br>
Brad
<br>
<br>
<br>
On 11/15/2016 4:12 PM, Wang Weijun wrote:
<br>
<blockquote type="cite">You create a debug field with a prefix
string and then check both debug != null and
Debug.isOn("policy") and then use System.out.println to print
the message. Something must be useless.
<br>
<br>
--Max
<br>
<br>
<blockquote type="cite">On Nov 16, 2016, at 3:31 AM, Bradford
Wetmore <a class="moz-txt-link-rfc2396E" href="mailto:bradford.wetmore@oracle.com"><bradford.wetmore@oracle.com></a> wrote:
<br>
<br>
Simple codereview:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~wetmore/8169335/webrev.00">http://cr.openjdk.java.net/~wetmore/8169335/webrev.00</a>
<br>
<br>
The "crypto.policy" Security property is normally
defined/configured in the java.security file at build time.
(e.g. "limited" or "unlimited") Rather than currently failing
catastrophically if this value doesn't exist, there should be
a sensible default if it is undeclared for whatever reason.
We will use a sane fallback value of "limited".
<br>
<br>
If the distribution has also removed the "limited" policy
directory then the VM will still fail to initialize, but we
have at least made an effort to recover.
<br>
<br>
Thanks,
<br>
<br>
Brad
<br>
<br>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</body>
</html>