<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Hi Artem Smotrakov,</p>
<p><br>
</p>
<p>I have included the changes mentioned, please review the same.</p>
<p><b>Webrev: </b><a
href="http://cr.openjdk.java.net/%7Ebgopularam/mavaluri/JDK-8164881/webrev.01/">http://cr.openjdk.java.net/~bgopularam/mavaluri/JDK-8164881/webrev.01/</a><b><br>
</b></p>
<br>
Regards,<br>
Mallikarjuna Avaluri<br>
<br>
<div class="moz-cite-prefix">On 11/16/2016 4:11 AM, Artem Smotrakov
wrote:<br>
</div>
<blockquote
cite="mid:addcba68-7b43-6580-1f84-b9b3a04fc0e8@oracle.com"
type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<p>Hi Mallikarjuna,</p>
<p>I have a couple of comments.<br>
</p>
<p>1. I see you extract DSA key size from
"jdk.certpath.disabledAlgorithms" security property. I think I
would be better not to rely on it, but expect that keys less
than 1024 bits are not allowed by default. You can pass a
boolean parameter to the test which defines what should be
expected.<br>
</p>
2. We are trying not to use lines more than 80 symbols. Could you
please fix it?<br>
<br>
3. Minor: DSAKeys.java line 342, you don't need to specify types
for HashMap<br>
<br>
4. It is up to you, but it would be good to update the test to use
SSTest.java (see examples in jdk/tests) because we've been seeing
intermittent failures of JSSE tests like this one you are updating<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/dev/jdk/file/93fb16cbdf7f/test/javax/net/ssl/templates/SSLTest.java">http://hg.openjdk.java.net/jdk9/dev/jdk/file/93fb16cbdf7f/test/javax/net/ssl/templates/SSLTest.java</a><br>
<br>
Artem<br>
<br>
<div class="moz-cite-prefix">On 11/13/2016 09:02 PM, Mallikarjuna
Avaluri wrote:<br>
</div>
<blockquote
cite="mid:c9c91738-4a37-38d2-773a-4e2fda6c3813@oracle.com"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
<p>Hi all,<br>
<br>
Please review the fix for following issue.<br>
<br>
JDK-8164881: Add more tests for JDK-8139565<br>
<a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8164881">https://bugs.openjdk.java.net/browse/JDK-8164881</a></p>
<p><b>Summary:</b> Currently
test/javax/net/ssl/TLSv12/DisabledShortDSAKeys.java checks
only that DSA keys with size of 512 bits are disabled. <br>
But we also need to check that DSA keys with sizes 1024 &
2048 are working fine.</p>
<br>
<b>Fix: </b> Currently
test/javax/net/ssl/TLSv12/DisabledShortDSAKeys.java checks only
that DSA keys with size of 512 bits are disabled.<br>
Added new tests with DSA keys with size of 960 bits disabled,
1024, 2048, 3072 bits enabled.<br>
<br>
<b>Webrev: </b> <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ebgopularam/mavaluri/JDK-8164881/webrev.00/">http://cr.openjdk.java.net/~bgopularam/mavaluri/JDK-8164881/webrev.00/</a><br>
<br>
<br>
Thanks,<br>
Mallikarjuna Avaluri </blockquote>
<br>
</blockquote>
<br>
</body>
</html>