<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Hello Goetz,</div><div class=""><br class=""></div><div class="">Please modify the bug summary to reference ECC too.</div><div class="">Your ECC changes look fine but the ‘Last Modified Date’ line in the 4 source code headers will need to be updated/added.</div><div class=""><div class=""><div class=""><br class=""></div><div class="">BTW p11_mutex.c is listed below but appears to be missing from the webrev.</div><div class=""><br class=""></div><div class="">Thanks.</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 30 Nov 2016, at 13:12, Lindenmaier, Goetz <<a href="mailto:goetz.lindenmaier@sap.com" class="">goetz.lindenmaier@sap.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="WordSection1" style="page: WordSection1; font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class="">Hi,<span class="Apple-converted-space"> </span><o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class=""><o:p class=""> </o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class="">I’d like to propose a row of smaller fixes<span class="Apple-converted-space"> </span></span><span lang="EN" style="font-size: 10.5pt; font-family: Arial, sans-serif; color: rgb(51, 51, 51);" class="">where code is noted down a bit questionable.<br class=""></span><span lang="EN-US" class="">SAP’s quality process requires that we fix these in our internal delivery, and I<o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class="">Would like to share my fixes with openJdk. Some of these fixes are of more<o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class="">theoretical nature as how I understand the code paths never allow the<o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class="">problematic situation, but fixing it nevertheless assures that nothing is<o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class="">overseen if the code changes. Most changes are in </span><span lang="EN" class="">libawt_xawt</span><span lang="EN-US" class="">, some<o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class="">are in<span class="Apple-converted-space"> </span></span><span lang="EN" class="">libsunec.</span><span lang="EN-US" class=""><o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class=""><o:p class=""> </o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class="">I’d appreciate a review:<o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class=""><a href="http://cr.openjdk.java.net/~goetz/wr16/8170525-awt/webrev.01/" style="color: rgb(149, 79, 114); text-decoration: underline;" class="">http://cr.openjdk.java.net/~goetz/wr16/8170525-awt/webrev.01/</a><o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class=""><o:p class=""> </o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN-US" class="">Changes in detail:<o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span lang="EN" style="font-size: 10.5pt; font-family: Arial, sans-serif; color: rgb(51, 51, 51);" class=""><br class="">awt_InputMethod.c:<span class="Apple-converted-space"> </span><br class=""><br class="">One might overrun the 100 byte fixed-size string statusWindow->status by copying text->string.multi_byte without checking the length.<span class="Apple-converted-space"> </span><br class=""><br class="">gtk3_interface.c:<span class="Apple-converted-space"> </span><br class=""><br class="">This less-than-zero comparison of an unsigned value is never true.<span class="Apple-converted-space"> </span><br class=""><br class="">Using uninitialized value color. Field color.alpha is uninitialized.<span class="Apple-converted-space"> </span><br class="">E.g. used at gtk3_interface.c:2287.<span class="Apple-converted-space"> </span><br class=""><br class="">XToolkit.c<span class="Apple-converted-space"> </span><br class=""><br class="">Using uninitialized value ret_timeout.<span class="Apple-converted-space"> </span><br class="">E.g. in XToolkit.c:6809.<span class="Apple-converted-space"> </span><br class=""><br class="">XWindow.c<span class="Apple-converted-space"> </span><br class=""><br class="">Argument is incompatible with corresponding format string conversion.<span class="Apple-converted-space"> </span><br class=""><br class="">splashscreen_sys.c<span class="Apple-converted-space"> </span><br class=""><br class="">Overflowed or truncated value (or a value computed from an overflowed or truncated value) (gdk_scale > 0) ? native_scale * (double)gdk_scale : native_scale used as return value.<span class="Apple-converted-space"> </span><br class=""><br class="">ec.c<span class="Apple-converted-space"> </span><br class=""><br class="">Using uninitialized value k.dp when calling mp_clear.<span class="Apple-converted-space"> </span><br class=""><br class="">ecdecode.c<span class="Apple-converted-space"> </span><br class=""><br class="">You might overrun the 291 byte fixed-size string genenc by copying curveParams->geny without checking the length.<span class="Apple-converted-space"> </span><br class="">Added sanity check before doing the string concatenation.<span class="Apple-converted-space"> </span><br class=""><br class="">ecl_mult.c<span class="Apple-converted-space"> </span><br class=""><br class="">Using uninitialized value kt.flag when calling *group->point_mul. (The function pointer resolves to ec_GF2m_pt_mul_mont.)<span class="Apple-converted-space"> </span><br class=""><br class="">mpi.c<span class="Apple-converted-space"> </span><br class=""><br class="">Using uninitialized value s. Field s.flag is uninitialized when calling s_mp_exch.<span class="Apple-converted-space"> </span><br class="">Using uninitialized value tmp. Field tmp.flag is uninitialized when calling s_mp_exch<span class="Apple-converted-space"> </span><br class="">Using uninitialized value t.dp when calling mp_clear.<span class="Apple-converted-space"> </span><br class=""><br class="">p11_mutex.c<span class="Apple-converted-space"> </span><br class=""><br class="">Using uninitialized value *ckpInitArgs. Field ckpInitArgs->flags is uninitialized when calling memcpy.<span class="Apple-converted-space"> </span><br class=""><br class=""><br class="">DataBufferNative.c<span class="Apple-converted-space"> </span><br class=""><br class="">Using uninitialized value lockInfo.rasBase when calling BN_GetPixelPointer.<span class="Apple-converted-space"> </span><br class=""><br class="">fontpath.c<span class="Apple-converted-space"> </span><br class=""><br class="">You might overrun the 512 byte fixed-size string fontDirPath by copying DirP->name[index] without checking the length.</span></div></div></div></blockquote></div><br class=""></div></div></div></body></html>