<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi, <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I’d like to propose a row of smaller fixes
</span><span lang="EN" style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#333333">where code is noted down a bit questionable.<br>
</span><span lang="EN-US">SAP’s quality process requires that we fix these in our internal delivery, and I
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Would like to share my fixes with openJdk. Some of these fixes are of more<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">theoretical nature as how I understand the code paths never allow the
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">problematic situation, but fixing it nevertheless assures that nothing is<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">overseen if the code changes. Most changes are in </span><span lang="EN">libawt_xawt</span><span lang="EN-US">, some<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">are in </span><span lang="EN">libsunec.</span><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I’d appreciate a review:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="http://cr.openjdk.java.net/~goetz/wr16/8170525-awt/webrev.01/">http://cr.openjdk.java.net/~goetz/wr16/8170525-awt/webrev.01/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Changes in detail:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN" style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#333333"><br>
awt_InputMethod.c: <br>
<br>
One might overrun the 100 byte fixed-size string statusWindow->status by copying text->string.multi_byte without checking the length.
<br>
<br>
gtk3_interface.c: <br>
<br>
This less-than-zero comparison of an unsigned value is never true. <br>
<br>
Using uninitialized value color. Field color.alpha is uninitialized. <br>
E.g. used at gtk3_interface.c:2287. <br>
<br>
XToolkit.c <br>
<br>
Using uninitialized value ret_timeout. <br>
E.g. in XToolkit.c:6809. <br>
<br>
XWindow.c <br>
<br>
Argument is incompatible with corresponding format string conversion. <br>
<br>
splashscreen_sys.c <br>
<br>
Overflowed or truncated value (or a value computed from an overflowed or truncated value) (gdk_scale > 0) ? native_scale * (double)gdk_scale : native_scale used as return value.
<br>
<br>
ec.c <br>
<br>
Using uninitialized value k.dp when calling mp_clear. <br>
<br>
ecdecode.c <br>
<br>
You might overrun the 291 byte fixed-size string genenc by copying curveParams->geny without checking the length.
<br>
Added sanity check before doing the string concatenation. <br>
<br>
ecl_mult.c <br>
<br>
Using uninitialized value kt.flag when calling *group->point_mul. (The function pointer resolves to ec_GF2m_pt_mul_mont.)
<br>
<br>
mpi.c <br>
<br>
Using uninitialized value s. Field s.flag is uninitialized when calling s_mp_exch.
<br>
Using uninitialized value tmp. Field tmp.flag is uninitialized when calling s_mp_exch
<br>
Using uninitialized value t.dp when calling mp_clear. <br>
<br>
p11_mutex.c <br>
<br>
Using uninitialized value *ckpInitArgs. Field ckpInitArgs->flags is uninitialized when calling memcpy.
<br>
<br>
<br>
DataBufferNative.c <br>
<br>
Using uninitialized value lockInfo.rasBase when calling BN_GetPixelPointer. <br>
<br>
fontpath.c <br>
<br>
You might overrun the 512 byte fixed-size string fontDirPath by copying DirP->name[index] without checking the length.</span><span lang="EN-US"><o:p></o:p></span></p>
</div>
</body>
</html>