<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Also, in gtk3_interface.c, there is this change for color.alpha<br>
</p>
<pre><span class="new">2219 color.alpha = 0; in </span>gtk3_get_color_for_flags()</pre>
<pre>but it is used in
gtk3_get_color_for_state() where it is not initialized
2268 GdkRGBA color;</pre>
Regards<br>
Prasanta<br>
<div class="moz-cite-prefix">On 12/1/2016 1:28 AM, Phil Race wrote:<br>
</div>
<blockquote
cite="mid:0b89193d-598d-77b0-4c92-0f19b4cea68f@oracle.com"
type="cite">Hi Goetz,
<br>
<br>
<blockquote type="cite"> DataBufferNative.c
<br>
Using uninitialized value lockInfo.rasBase when calling
DBN_GetPixelPointer.
<br>
</blockquote>
<br>
75 lockInfo.resBase = NULL;
<br>
<br>
Did you actually compile this ? The variable is called "rasBase",
not "resBase".
<br>
<br>
And strictly there is no problem since inside DBN_GetPixelPointer
<br>
the code calls ops->Lock which should initialise this.
<br>
A "rasBase" of 0 isn't really any better than a random one ..
<br>
<br>
Also I don't see why there's a problem here and not in
<br>
the function immediately following since it is the exact same
case.
<br>
<br>
-phil.
<br>
<br>
On 11/30/2016 10:00 AM, Sergey Bylokhov wrote:
<br>
<blockquote type="cite">cc 2d-dev.
<br>
<br>
On 30.11.16 18:41, Lindenmaier, Goetz wrote:
<br>
<blockquote type="cite">Hi Vincent,
<br>
<br>
thanks for the quit review!
<br>
Good catch that I lost the change to p11_mutex.c ... I had to
change
<br>
it and it fell out of my patches.
<br>
I edited the Last Modified Date, and also updated the
copyright messages.
<br>
New webrev:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~goetz/wr16/8170525-awt-dev/">http://cr.openjdk.java.net/~goetz/wr16/8170525-awt-dev/</a>
<br>
<br>
Best regards,
<br>
Goetz.
<br>
<br>
(Am I correct that your openJdk name is Vinnie?)
<br>
<br>
<blockquote type="cite">-----Original Message-----
<br>
From: Vincent Ryan [<a class="moz-txt-link-freetext" href="mailto:vincent.x.ryan@oracle.com">mailto:vincent.x.ryan@oracle.com</a>]
<br>
Sent: Mittwoch, 30. November 2016 14:53
<br>
To: Lindenmaier, Goetz <a class="moz-txt-link-rfc2396E" href="mailto:goetz.lindenmaier@sap.com"><goetz.lindenmaier@sap.com></a>
<br>
Cc: <a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>; <a class="moz-txt-link-abbreviated" href="mailto:security-dev@openjdk.java.net">security-dev@openjdk.java.net</a>
<br>
Subject: Re: RFR(M): 8170525: Fix minor issues in awt coding
<br>
<br>
Hello Goetz,
<br>
<br>
Please modify the bug summary to reference ECC too.
<br>
Your ECC changes look fine but the ‘Last Modified Date’ line
in the 4 source
<br>
code headers will need to be updated/added.
<br>
<br>
BTW p11_mutex.c is listed below but appears to be missing
from the webrev.
<br>
<br>
Thanks.
<br>
<br>
<br>
<br>
<br>
On 30 Nov 2016, at 13:12, Lindenmaier, Goetz
<br>
<<a class="moz-txt-link-abbreviated" href="mailto:goetz.lindenmaier@sap.com">goetz.lindenmaier@sap.com</a>
<a class="moz-txt-link-rfc2396E" href="mailto:goetz.lindenmaier@sap.com"><mailto:goetz.lindenmaier@sap.com></a> > wrote:
<br>
<br>
Hi,
<br>
<br>
I’d like to propose a row of smaller fixes where code is
noted down a
<br>
bit questionable.
<br>
SAP’s quality process requires that we fix these in our
internal delivery,
<br>
and I
<br>
Would like to share my fixes with openJdk. Some of
these fixes are of
<br>
more
<br>
theoretical nature as how I understand the code paths
never allow the
<br>
problematic situation, but fixing it nevertheless
assures that nothing is
<br>
overseen if the code changes. Most changes are in
libawt_xawt, some
<br>
are in libsunec.
<br>
<br>
I’d appreciate a review:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~goetz/wr16/8170525-awt/webrev.01/">http://cr.openjdk.java.net/~goetz/wr16/8170525-awt/webrev.01/</a>
<br>
<br>
Changes in detail:
<br>
<br>
awt_InputMethod.c:
<br>
<br>
One might overrun the 100 byte fixed-size string
statusWindow->status
<br>
by copying text->string.multi_byte without checking the
length.
<br>
<br>
gtk3_interface.c:
<br>
<br>
This less-than-zero comparison of an unsigned value is
never true.
<br>
<br>
Using uninitialized value color. Field color.alpha is
uninitialized.
<br>
E.g. used at gtk3_interface.c:2287.
<br>
<br>
XToolkit.c
<br>
<br>
Using uninitialized value ret_timeout.
<br>
E.g. in XToolkit.c:6809.
<br>
<br>
XWindow.c
<br>
<br>
Argument is incompatible with corresponding format
string conversion.
<br>
<br>
splashscreen_sys.c
<br>
<br>
Overflowed or truncated value (or a value computed from
an
<br>
overflowed or truncated value) (gdk_scale > 0) ?
native_scale *
<br>
(double)gdk_scale : native_scale used as return value.
<br>
<br>
ec.c
<br>
<br>
Using uninitialized value k.dp when calling mp_clear.
<br>
<br>
ecdecode.c
<br>
<br>
You might overrun the 291 byte fixed-size string genenc
by copying
<br>
curveParams->geny without checking the length.
<br>
Added sanity check before doing the string
concatenation.
<br>
<br>
ecl_mult.c
<br>
<br>
Using uninitialized value kt.flag when calling
*group->point_mul. (The
<br>
function pointer resolves to ec_GF2m_pt_mul_mont.)
<br>
<br>
mpi.c
<br>
<br>
Using uninitialized value s. Field s.flag is
uninitialized when calling
<br>
s_mp_exch.
<br>
Using uninitialized value tmp. Field tmp.flag is
uninitialized when
<br>
calling s_mp_exch
<br>
Using uninitialized value t.dp when calling mp_clear.
<br>
<br>
p11_mutex.c
<br>
<br>
Using uninitialized value *ckpInitArgs. Field
ckpInitArgs->flags is
<br>
uninitialized when calling memcpy.
<br>
<br>
<br>
DataBufferNative.c
<br>
<br>
Using uninitialized value lockInfo.rasBase when calling
<br>
BN_GetPixelPointer.
<br>
<br>
fontpath.c
<br>
<br>
You might overrun the 512 byte fixed-size string
fontDirPath by copying
<br>
DirP->name[index] without checking the length.
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>