<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi,<div class=""><br class=""></div><div class="">+1 (I am not really an expert on jar signing but the basic test looks fine).</div><div class=""><br class=""></div><div class="">Some minor comments below, no need for another review.</div><div class=""><br class=""></div><div class="">Paul.</div><div class=""><br class=""></div><div class=""><pre style="orphans: 2; widows: 2;" class=""> 113 Stream.of(sourceFiles).map(Object::toString).forEach(x -> launcher.addToolArg(x));
</pre></div><div class=""><pre style="orphans: 2; widows: 2;" class=""> 119 Stream.of(args).forEach(x -> launcher.addToolArg(x));
</pre></div><div class="">If you like you can do:</div><div class=""><br class=""></div><div class=""> launcher::addToolArg</div><div class=""><br class=""></div><div class=""><pre style="orphans: 2; widows: 2;" class=""> 148 private static OutputAnalyzer verify (String signedJarName) throws Throwable {
</pre></div><div class="">Rogue ‘ ‘ between the method name and it’s parameter list.</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""><div class="">On 12 Dec 2016, at 14:43, Amanda Jiang <<a href="mailto:amanda.jiang@oracle.com" class="">amanda.jiang@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Hi All,<br class=""><br class="">Please help to review following changeset, which tests that jarsigner tool works with multi-release JAR files.<br class=""><br class="">Webrev: <a href="http://cr.openjdk.java.net/~amjiang/8075618/webrev.01/" class="">http://cr.openjdk.java.net/~amjiang/8075618/webrev.01/</a><br class="">Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8075618" class="">https://bugs.openjdk.java.net/browse/JDK-8075618</a><br class=""><br class=""><br class="">Thanks,<br class="">Amanda<br class=""></div></blockquote></div><br class=""></div></body></html>