<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
src/java.base/share/classes/sun/security/util/SignatureFileVerifier.java<br>
<br>
CertPathValidatorException is caught 3 times in new code but we're
not printing out the exact algorithm that caused the exception.
AFAIK, that should be in the exception message. Would it be possible
to use something e.getMessage() call to print more detail ? You'd
have to check for null also.<br>
<br>
371 } catch(CertPathValidatorException e) {<br>
372 if (debug != null) {<br>
373 debug.println(key + " uses a disabled
algorithm.");<br>
374 }<br>
<br>
Spacing issue on line 371 of same file : <br>
<br>
<blockquote type="cite">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: 1; word-spacing: 0px; -webkit-text-stroke-width: 0px;">371 } catch(CertPathValidatorException e) {</pre>
</blockquote>
<pre class="moz-signature" cols="72">Regards,
Sean.</pre>
<div class="moz-cite-prefix">On 26/01/17 21:57, Sean Mullan wrote:<br>
</div>
<blockquote
cite="mid:7f3ecacd-bc30-3b59-0fc5-2409042c1bd9@oracle.com"
type="cite">Looks good, mostly minor stuff so far, just have one
other file I need more time to review:
<br>
<br>
* java.security
<br>
<br>
Update description of new constraints to match CCC.
<br>
<br>
* PKIXExtendedParameters.java
<br>
<br>
Update class description (it is out-of-date).
<br>
<br>
* CertConstraintParameters.java
<br>
<br>
2 * Copyright (c) 2016, 2017 Oracle and/or its affiliates. All
rights reserved.
<br>
<br>
Should be a comma after 2017.
<br>
<br>
* AlgorithmChecker.java
<br>
<br>
278 String currSigAlg =
((X509Certificate)cert).getSigAlgName();
<br>
<br>
Just use x509Cert.getSigAlgName() instead
<br>
<br>
* SignatureFileVerifier.java
<br>
<br>
294 Timestamp[] timestamp = new
Timestamp[newSigners.length];
<br>
<br>
"timestamps" would be more clear as a variable name
<br>
<br>
299 System.out.println("Timestamp[" + (i - 1) + "]
= " +
<br>
<br>
debug.println
<br>
<br>
--Sean
<br>
<br>
On 1/23/17 6:27 PM, Anthony Scarpino wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
I need a code review of this change that brings more detail
constraints
<br>
checking and control to certpath and jar disabled algorithm
Security
<br>
properties.
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~ascarpino/8160655/webrev/">http://cr.openjdk.java.net/~ascarpino/8160655/webrev/</a>
<br>
<br>
thanks
<br>
<br>
Tony
<br>
</blockquote>
</blockquote>
<br>
</body>
</html>