<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFE0">
Hi Mandy,<br>
<br>
<div class="moz-cite-prefix">On 8/3/2017 4:13 PM, Mandy Chung wrote:<br>
</div>
<blockquote type="cite"
cite="mid:2B758FD9-3203-4740-80D1-1805832ACF2C@oracle.com">
<pre wrap="">Thanks for doing this. It’s good to see JDK finalizes being replaced.
It looks good to me. I wonder if there is any existing security utility class that may be a good place for this zero-ing byte array method to share. Sean and other may have opinion.</pre>
</blockquote>
There are very few of these cases and I think it is better to keep
the code close to the use.<br>
If there's good place to put a method for this purpose, let me know.<br>
<br>
Thanks, Roger<br>
<br>
<blockquote type="cite"
cite="mid:2B758FD9-3203-4740-80D1-1805832ACF2C@oracle.com">
<pre wrap="">
Mandy
</pre>
<blockquote type="cite">
<pre wrap="">On Aug 3, 2017, at 1:01 PM, Roger Riggs <a class="moz-txt-link-rfc2396E" href="mailto:Roger.Riggs@oracle.com"><Roger.Riggs@oracle.com></a> wrote:
Found a race in the tests between the Cleaner clearing the arrays and the test waiting for the key to be freed.
Revised to continuously check the arrays and exit when they are cleared. If not cleared the test will timeout.
Updated the webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~rriggs/webrev-crypt-finalize-8184744/">http://cr.openjdk.java.net/~rriggs/webrev-crypt-finalize-8184744/</a>
Thanks, Roger
On 8/3/2017 9:58 AM, Roger Riggs wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Please review replacing finalize with java.lang.ref.Cleaner in a few simple cases.
Webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~rriggs/webrev-crypt-finalize-8184744/">http://cr.openjdk.java.net/~rriggs/webrev-crypt-finalize-8184744/</a>
Thanks, Roger
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>