<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Tony pointed out off-list that the change to encodeISOArray()
might not work.</p>
<p>"I'm not certain the change to encodeISOArray() is not going to
work. In 8, that method can be replaced by an intrinsic and miss
your additional check. Unlike in 9 where implEncodeISOArray() is
intrinsfied. It maybe best to backport the method name change
done in 9 too."</p>
<p>I replied :</p>
<p>"That's a fair point Tony. Without risking too much change for
jdk8u-dev, would it be ok to ensure that the len value is not
<= 0 before we call the method itself. There are only two call
sites. Refactoring of various methods too place in JDK 9 and
introduced implEncodeISOArray in that class. [1]. I think the
change I'm proposing is just as useful and safer :
<br>
<br>
new webrev :
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~coffeys/webrev.8159035.8u.02/webrev/">http://cr.openjdk.java.net/~coffeys/webrev.8159035.8u.02/webrev/</a>"</p>
<p>The security-dev list got dropped. Re-adding here.<br>
</p>
<pre class="moz-signature" cols="72">Regards,
Sean.</pre>
<div class="moz-cite-prefix">On 16/08/17 13:14, Seán Coffey wrote:<br>
</div>
<blockquote
cite="mid:3b6494f6-9bd5-bc4a-651e-1a4b6fc28ba9@oracle.com"
type="cite">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<p>Looking to backport this fix to jdk8u-dev. The bug report is
not public but the JDK 9 review thread captures the details. The
fix is similar. Some extra intrinsics work in jdk9 wasn't
applicable for the jdk8u-dev port. <br>
</p>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-November/044560.html">http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-November/044560.html</a>
<br>
webrev : <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ecoffeys/webrev.8159035.8u/webrev/">http://cr.openjdk.java.net/~coffeys/webrev.8159035.8u/webrev/</a>
<br>
<pre class="moz-signature" cols="72">--
Regards,
Sean.</pre>
</blockquote>
<br>
</body>
</html>