<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
Line 196 of LdapLoginModule.java seems to miss a </dd>?<br>
Rest of webrev look fine.<br>
Valerie<br>
<br>
<div class="moz-cite-prefix">On 3/6/2018 5:38 PM, Weijun Wang wrote:<br>
</div>
<blockquote type="cite"
cite="mid:A29094E6-003B-4562-B623-D4381B95C9CD@oracle.com">Please
take a review at<br class="">
<br class="">
<a
href="http://cr.openjdk.java.net/%7Eweijun/8199154/webrev.00/"
class="" moz-do-not-send="true">http://cr.openjdk.java.net/~weijun/8199154/webrev.00/</a><br
class="">
<br class="">
In LdapLoginModule.java, there seems to be an erroneous DL inside
DL. I removed the outer DL and its incomplete DD. There is no
visual difference after the change.<br class="">
<br class="">
In Krb5LoginModule.java, there were only DDs and no DT. I've
simply removed all D? tags. The output is little more compact. See
the attached screenshot.
<div class=""><br class="">
<img apple-inline="yes"
id="1B5C1636-E14C-4829-ADC4-7F03B82A244E"
src="imap://valerie%2Epeng%40oracle%2Ecom@stbeehive.oracle.com:993/fetch%3EUID%3E/INBOX%3E305826?header=quotebody/;section=2.2?part=1.2.2&filename=auth-dd.jpeg"
class="" moz-do-not-send="true" height="240" width="294"><br
class="">
<br class="">
</div>
<div class="">Thanks<br class="">
Max</div>
</blockquote>
<br>
</body>
</html>