<div dir="ltr">Hi Sean,<div><br></div><div>This is a simple patch that contains:</div><div><br></div><div> 1) a fix on the SQL db prefix: it should be sql: instead of sql:/ to avoid path errors (triggered on a new NSS library version);</div><div> 2) minor enhancement to specify a pkcs11.txt configuration file (as secmod.db was used before, for the legacy db); and,</div><div> 3) some minor debugging enhancements to get error codes out of NSS.</div><div><br></div><div>I'll be grateful if someone can have a look at it. This proposal fixes an existing bug, that can be verified with Oracle's internal tests.</div><div><br></div><div>I'm CC' Max to this email, as he was the one who notified me about the bug.</div><div><br></div><div>Kind regards,</div><div>Martin.-</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 14, 2018 at 3:04 PM, Seán Coffey <span dir="ltr"><<a href="mailto:sean.coffey@oracle.com" target="_blank">sean.coffey@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<p>I'll have a look Martin, but it'll be better if we can get an NSS
or PKCS11 expert to take a look. Any takers ? Can you expand some
bit on the exact reason for your 8195607 changes ? Pointers to NSS
changes etc. ?<br>
</p>
<pre class="m_6818221798889822642moz-signature" cols="72">Regards,
Sean.</pre><div><div class="h5">
<div class="m_6818221798889822642moz-cite-prefix">On 14/03/18 16:11, Martin Balao wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi Sean,
<div><br>
</div>
<div>Thanks!</div>
<div><br>
</div>
<div>Can you please review the fix [0] so we have it in? As far
as I know, fix makes Oracle internal tests pass.</div>
<div><br>
</div>
<div>Kind regards,</div>
<div>Martin.-</div>
<div><br>
</div>
<div>--</div>
<div>[0] - <a href="http://mail.openjdk.java.net/pipermail/security-dev/2018-February/016776.html" style="font-size:12.8px" target="_blank">http://mail.openjdk.java.net<wbr>/pipermail/security-dev/2018-<wbr>February/016776.html</a><span style="font-size:12.8px"> </span></div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Mar 14, 2018 at 12:05 PM, Seán
Coffey <span dir="ltr"><<a href="mailto:sean.coffey@oracle.com" target="_blank">sean.coffey@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<p>Hi Martin, <br>
</p>
<p>Thanks for the 8195607 pointer. I'll get this ported to
jdk8u also. I didn't see that actual issue during
testing but no harm to port it. Will submit a new webrev
shortly.<br>
</p>
<pre class="m_6818221798889822642m_9220356643261423839moz-signature" cols="72">Regards,
Sean.</pre>
<div>
<div class="m_6818221798889822642h5">
<div class="m_6818221798889822642m_9220356643261423839moz-cite-prefix">On
14/03/18 14:55, Martin Balao wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi Sean,
<div><br>
</div>
<div>Is this related to <a href="http://mail.openjdk.java.net/pipermail/security-dev/2018-February/016776.html" target="_blank">http://mail.openjdk.java.ne<wbr>t/pipermail/security-dev/2018-<wbr>February/016776.html</a> ?</div>
<div><br>
</div>
<div>Kind regards,</div>
<div>Martin.-</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Mar 14, 2018 at
11:48 AM, Seán Coffey <span dir="ltr"><<a href="mailto:sean.coffey@oracle.com" target="_blank">sean.coffey@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Looking to backport
this fix to jdk8u-dev. Contributed to JDK
Project by Martin Balao.<br>
<br>
<a href="https://bugs.openjdk.java.net/browse/JDK-8165996" rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/<wbr>browse/JDK-8165996</a><br>
webrev : <a href="http://cr.openjdk.java.net/%7Ecoffeys/webrev.8165996.8u/webrev/" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~co<wbr>ffeys/webrev.8165996.8u/webrev<wbr>/</a><br>
<br>
The test/jdk/sun/security/pkcs11/P<wbr>KCS11Test.java
edits didn't seem applicable to jdk8u.<br>
<br>
Also, I edited sun/security/pkcs11/Secmod/Tes<wbr>tNssDbSqlite.java
to exclude test where NSS Provider<br>
didn't register. (line 66). In particular, I
saw this while running 32bit JDK tests on 64
bit Linux.<span class="m_6818221798889822642m_9220356643261423839HOEnZb"><font color="#888888"><br>
<br>
-- <br>
Regards,<br>
Sean.<br>
<br>
</font></span></blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div>