<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Jamil,</p>
<p>1) where there any guidelines about how the engineToString should
be formatted ?<br>
I ask because i wondering why we need two new lines with access to
the System property.<br>
If it is represented as single line json no need to line break
would be needed.</p>
<p>Gruß Thomas<br>
</p>
<p><br>
</p>
/** * Creates a formatted string describing the parameters. * *
@return a string representation of the ChaCha20 parameters. */
@Override protected String engineToString() { String LINE_SEP =
System.getProperty("line.separator"); HexDumpEncoder encoder = new
HexDumpEncoder(); StringBuilder sb = new StringBuilder(LINE_SEP +
"nonce:" + LINE_SEP + "[" + encoder.encodeBuffer(nonce) + "]");
return sb.toString(); }
<pre>
2) I do not think it is an good idea to say no secureRandom=null will cause IV to be null.
I see here the risk of weak implementations. I would suggest to throw an Exception to
enforce secure usages. If someone really want an insecure IV he can provide am SecureRandom
implementation retuning 0 only or an matching IV.
* @param random a {@code SecureRandom} implementation. If {@code null}
* is used for the random object, then a nonce consisting of all
* zero bytes will be used. Otherwise a random nonce will be
* used.
3) If ChaCha20ParameterSpec would extends IvParameterSpec if would be valid for booth modes in engineInit.
Even if the counter is not needed.
As an alternative i would allow ChaCha20ParameterSpec also for AEAD mode.
Grup Thomas
</pre>
<div class="moz-cite-prefix">On 3/26/2018 9:08 PM, Jamil Nimeh
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:fc48175f-0209-2254-0d96-263f2016befe@oracle.com">Hello
all,
<br>
<br>
This is a request for review for the ChaCha20 and
ChaCha20-Poly1305 cipher implementations. Links to the webrev and
the JEP which outlines the characteristics and behavior of the
ciphers are listed below.
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jnimeh/reviews/8153028/webrev.01/">http://cr.openjdk.java.net/~jnimeh/reviews/8153028/webrev.01/</a>
<br>
<a class="moz-txt-link-freetext" href="http://openjdk.java.net/jeps/329">http://openjdk.java.net/jeps/329</a>
<br>
<br>
Thanks,
<br>
--Jamil
<br>
</blockquote>
</body>
</html>