<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>I have a couple of minor comments. I am not a Reviewer, so
someone else will still need to look at this. <br>
</p>
<p>KeySizeTest: You can use the byteArrayToHexString that is in
Convert in the test lib. See TestXDH.java for an example of how
this method is imported and used. <br>
MultiThreadTest: In testKeyAgreement, you may want to generate two
key pairs, do two key agreement operations, and then compare the
results. Then this test could catch arithmetic errors caused by
caching and precomputation. <br>
</p>
<br>
<div class="moz-cite-prefix">On 3/26/2018 12:38 PM, Sibabrata Sahoo
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:dff50f25-538d-4659-982f-4c659caa4c7c@default">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review the patch for,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">JBS: <a
href="https://bugs.openjdk.java.net/browse/JDK-8184359"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8184359</a><o:p></o:p></p>
<p class="MsoNormal">Webrev: <a
href="http://cr.openjdk.java.net/%7Essahoo/8184359/webrev.00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~ssahoo/8184359/webrev.00/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">All the Test files uses KeyAgreement,
KeyPairGenerator, Several KeySpecs from SunJCE library to Test
DiffieHellman, ECDH and XDH with curve25519 and curve448
algorithms. Each Test files try to address several cases and
the purpose of each has been commented in their own files.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Siba<o:p></o:p></p>
</div>
</blockquote>
<br>
</body>
</html>