<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Xuelei,<br>
</p>
<src/java.base/share/classes/sun/security/ssl/SSLKeyExchange.java><br>
- line 2, why is the copyright year changed from 2015 only to 2003
and 2018? Don't we normally preserve the first year and only
update/add the second year?<br>
- line 110, instead of erroring out, I wonder if it's better to call
createPossessions(<span class="new">handshakeContext) and only error
out if the result is more than one.</span><br>
<span class="new">- line 421 and 464, RSA is left out for these two
cases, is this asymmetry (comparing to line 381 and 494)
intentional?</span><br>
<span class="new"></span><br>
<src/java.base/share/classes/sun/security/ssl/RSAServerKeyExchange.java><br>
- line 2, for a new file, shouldn't there be only one year, i.e.
2018?<br>
- line 219, is this INSTANCE really used? I did a quick search and
didn't find reference to it.<br>
- line 309, why is EC mentioned here? Typo perhaps?<br>
<br>
<src/java.base/share/classes/sun/security/ssl/ServerKeyExchange.java><br>
- line 2, for a new file, shouldn't there be only one year, i.e.
2018?<br>
- line 89, typo: "producing" should be "consuming"<br>
- line 107, typo: "not" should be "no"<br>
<br>
Thanks,<br>
Valerie<br>
<br>
<div class="moz-cite-prefix">On 5/25/2018 4:45 PM, Xuelei Fan wrote:<br>
</div>
<blockquote type="cite"
cite="mid:9a98c066-d214-5d47-f8ca-473adefe9d42@oracle.com">Hi,
<br>
<br>
I'd like to invite you to review the TLS 1.3 implementation. I
appreciate it if I could have compatibility and specification
feedback before May 31, 2018, and implementation feedback before
June 7, 2018.
<br>
<br>
Here is the webrev:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~xuelei/8196584/webrev-full.00">http://cr.openjdk.java.net/~xuelei/8196584/webrev-full.00</a>
<br>
<br>
The formal TLS 1.3 specification is not finalized yet, although it
had been approved to be a standard. The implementation is based
on the draft version 28:
<br>
<a class="moz-txt-link-freetext" href="https://tools.ietf.org/html/draft-ietf-tls-tls13-28">https://tools.ietf.org/html/draft-ietf-tls-tls13-28</a>
<br>
<br>
For the overall description of this enhancement, please refer to
JEP 332:
<br>
<a class="moz-txt-link-freetext" href="http://openjdk.java.net/jeps/332">http://openjdk.java.net/jeps/332</a>
<br>
<br>
For the compatibility and specification update, please refer to
CSR 8202625:
<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8202625">https://bugs.openjdk.java.net/browse/JDK-8202625</a>
<br>
<br>
Note that we are using the sandbox for the development right now.
For more information, please refer to Bradford's previous email:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://mail.openjdk.java.net/pipermail/security-dev/2018-May/017139.html">http://mail.openjdk.java.net/pipermail/security-dev/2018-May/017139.html</a>
<br>
<br>
Thanks & Regards,
<br>
Xuelei
<br>
</blockquote>
<br>
</body>
</html>