<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Siba,<br>
165 System.setProperty("jdk.tls13.version", "7F1C");<br>
This property may be unnecessary.<br>
JSSE server and client just use the same TLS 1.3 version number,
regardless of what the number is.<br>
<br>
322 KeyStore ts = KeyStore.getInstance("JKS");<br>
323 KeyStore ks = KeyStore.getInstance("JKS");<br>
Would it be better to use PKCS12?<br>
<br>
424 // EC private key related to cert
endEntityCertStrs[0].<br>
451 // EC private key related to cert
endEntityCertStrs[0].<br>
489 // RSA private key related to cert
endEntityCertStrs[0].<br>
581 // RSA private key related to cert
endEntityCertStrs[0].<br>
...<br>
What's the mean of these comments?<br>
<br>
220 void doServerSide() throws Exception<br>
288 void doClientSide() throws Exception<br>
Could you apply try-with-resources to sslServerSocket and
sslSocket in the above two methods?<br>
<br>
157 private volatile static boolean clientRenegoReady =
false;<br>
...<br>
246 while (!clientRenegoReady) {<br>
247 System.out.println("Waiting for
ClientHello");<br>
248 Thread.sleep(50);<br>
249 }<br>
Why does clientRenegoReady exist?<br>
I don't see the value of clientRenegoReady is changed.<br>
Because clientRenegoReady always is false, so "while
(!clientRenegoReady)" should be as the same as "while(true)".<br>
And, what's the purpose of this while block?<br>
I assume you want to make sure that server doesn't exit before the
second handshaking finishes.<br>
If true, in practice, do you get the case: Before client side
socket I/O closes, server already exits?<br>
<br>
In addition, why not building case combinations in the codes?<br>
It would not be easy to maintain so many hard-coded combinations
in @run lines.<br>
And generally, this style may increase gross test execution time.<br>
<br>
Best regards,<br>
John Jiang<br>
</p>
<div class="moz-cite-prefix">On 21/06/2018 14:58, Sibabrata Sahoo
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:528299c6-d5a1-4564-9dd7-7f0e1b8a7c89@default">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi Xuelei,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review the patch for,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">JBS: <a
href="https://bugs.openjdk.java.net/browse/JDK-8205111"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8205111</a><o:p></o:p></p>
<p class="MsoNormal">Webrev: <a
href="http://cr.openjdk.java.net/%7Essahoo/8205111/webrev.00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~ssahoo/8205111/webrev.00/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Change:<o:p></o:p></p>
<p class="MsoNormal">This Test file verifies all TLS protocols
with the supported keytypes.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Siba<o:p></o:p></p>
</div>
</blockquote>
<br>
</body>
</html>