<div dir="ltr">Hi,<div><br></div><div>That's correct: <span style="font-size:12.8px">TestTLS12.java was introduced by this patch and is checking that the new feature (TLS 1.2 + SunPKCS11) is working correctly. If the PKCS11 library does not support TLS 1.2 mechanisms, the test must fail. This test should be skipped on those configurations.</span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">Kind regards,</span></div><div><span style="font-size:12.8px">Martin.-</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 26, 2018 at 7:44 PM, Valerie Peng <span dir="ltr"><<a href="mailto:valerie.peng@oracle.com" target="_blank">valerie.peng@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<p>Update: I submitted your webrev.05 through Mach5, there are one
test failure observed on 4 configurations, all are due to the
regression test TestTLS12.java. It looks like the test fails when
the underlying PKCS11 library does not support the corresponding
TLS 12 mechanisms (stacktrace included as below)</p>
<pre>jib > STDERR:
jib > java.security.<wbr>ProviderException: Could not generate key
jib > at jdk.crypto.cryptoki/sun.<wbr>security.pkcs11.<wbr>P11TlsMasterSecretGenerator.<wbr>engineGenerateKey(<wbr>P11TlsMasterSecretGenerator.<wbr>java:181)
jib > at java.base/javax.crypto.<wbr>KeyGenerator.generateKey(<wbr>KeyGenerator.java:563)
jib > at TestTLS12.<wbr>testTlsAuthenticationCodeGener<wbr>ation(TestTLS12.java:181)
jib > at TestTLS12.main(TestTLS12.java:<wbr>104)
jib > at java.base/jdk.internal.<wbr>reflect.<wbr>NativeMethodAccessorImpl.<wbr>invoke0(Native Method)
jib > at java.base/jdk.internal.<wbr>reflect.<wbr>NativeMethodAccessorImpl.<wbr>invoke(<wbr>NativeMethodAccessorImpl.java:<wbr>62)
jib > at java.base/jdk.internal.<wbr>reflect.<wbr>DelegatingMethodAccessorImpl.<wbr>invoke(<wbr>DelegatingMethodAccessorImpl.<wbr>java:43)
jib > at java.base/java.lang.reflect.<wbr>Method.invoke(Method.java:566)
jib > at com.sun.javatest.regtest.<wbr>agent.MainWrapper$MainThread.<wbr>run(MainWrapper.java:115)
jib > at java.base/java.lang.Thread.<wbr>run(Thread.java:834)
jib > Caused by: sun.security.pkcs11.wrapper.<wbr>PKCS11Exception: CKR_MECHANISM_INVALID
jib > at jdk.crypto.cryptoki/sun.<wbr>security.pkcs11.wrapper.<wbr>PKCS11.C_DeriveKey(Native Method)
jib > at jdk.crypto.cryptoki/sun.<wbr>security.pkcs11.<wbr>P11TlsMasterSecretGenerator.<wbr>engineGenerateKey(<wbr>P11TlsMasterSecretGenerator.<wbr>java:167)
jib > ... 9 more
jib >
jib > JavaTest Message: Test threw exception: java.security.<wbr>ProviderException: Could not generate key
jib > JavaTest Message: shutting down test
jib >
jib > STATUS:Failed.`main' threw exception: java.security.<wbr>ProviderException: Could not generate key</pre>
Thanks,<br>
Valerie<div><div class="h5"><br>
<br>
<div class="m_-5792028433874797567moz-cite-prefix">On 7/23/2018 9:50 PM, Martin Balao
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>Hi Valerie,</div>
<div><br>
</div>
<div>Webrev 05:</div>
<div><br>
</div>
<div> * <a href="http://cr.openjdk.java.net/%7Embalao/webrevs/8029661/8029661.webrev.05/" target="_blank">http://cr.openjdk.java.net/~<wbr>mbalao/webrevs/8029661/<wbr>8029661.webrev.05/</a></div>
<div> * <a href="http://cr.openjdk.java.net/%7Embalao/webrevs/8029661/8029661.webrev.05.zip" target="_blank">http://cr.openjdk.java.net/~<wbr>mbalao/webrevs/8029661/<wbr>8029661.webrev.05.zip</a></div>
<div><br>
</div>
<div>New in Webrev 05:</div>
<div><br>
</div>
<div> * Explicitly casted prfHashMechanism to CK_MECHANISM_TYPE
type to avoid building warning on some compilers (it's a long
-> unsigned long cast).</div>
<div><br>
</div>
<div>Regression tests result for jdk/sun/security/pkcs11
category:</div>
<div><br>
</div>
<div>Passed: sun/security/pkcs11/Cipher/<wbr>JNICheck.java</div>
<div>Passed: sun/security/pkcs11/Cipher/<wbr>ReinitCipher.java</div>
<div>Passed:
sun/security/pkcs11/Cipher/<wbr>TestPKCS5PaddingError.java</div>
<div>Passed: sun/security/pkcs11/Cipher/<wbr>TestRawRSACipher.java</div>
<div>Passed: sun/security/pkcs11/Cipher/<wbr>TestRSACipher.java</div>
<div>Passed: sun/security/pkcs11/Cipher/<wbr>TestRSACipherWrap.java</div>
<div>Passed: sun/security/pkcs11/Cipher/<wbr>TestSymmCiphers.java</div>
<div>Passed:
sun/security/pkcs11/Cipher/<wbr>TestSymmCiphersNoPad.java</div>
<div>Passed: sun/security/pkcs11/Config/<wbr>ReadConfInUTF16Env.sh</div>
<div>Passed: sun/security/pkcs11/ec/<wbr>ReadCertificates.java</div>
<div>Passed: sun/security/pkcs11/ec/<wbr>ReadPKCS12.java</div>
<div>Passed: sun/security/pkcs11/ec/<wbr>TestCurves.java</div>
<div>Passed: sun/security/pkcs11/ec/<wbr>TestECDH.java</div>
<div>Passed: sun/security/pkcs11/ec/<wbr>TestECDH2.java</div>
<div>Passed: sun/security/pkcs11/ec/<wbr>TestECDSA.java</div>
<div>Passed: sun/security/pkcs11/ec/<wbr>TestECDSA2.java</div>
<div>Passed: sun/security/pkcs11/ec/<wbr>TestECGenSpec.java</div>
<div>FAILED: sun/security/pkcs11/ec/<wbr>TestKeyFactory.java</div>
<div>Passed: sun/security/pkcs11/fips/<wbr>ClientJSSEServerJSSE.java</div>
<div>Passed: sun/security/pkcs11/fips/<wbr>TrustManagerTest.java</div>
<div>Passed:
sun/security/pkcs11/<wbr>KeyAgreement/SupportedDHKeys.<wbr>java</div>
<div>Passed: sun/security/pkcs11/<wbr>KeyAgreement/TestDH.java</div>
<div>Passed: sun/security/pkcs11/<wbr>KeyAgreement/TestInterop.java</div>
<div>Passed: sun/security/pkcs11/<wbr>KeyAgreement/TestShort.java</div>
<div>Passed:
sun/security/pkcs11/<wbr>KeyAgreement/<wbr>UnsupportedDHKeys.java</div>
<div>Passed: sun/security/pkcs11/<wbr>KeyGenerator/DESParity.java</div>
<div>Passed:
sun/security/pkcs11/<wbr>KeyGenerator/TestKeyGenerator.<wbr>java</div>
<div>Passed:
sun/security/pkcs11/<wbr>KeyPairGenerator/TestDH2048.<wbr>java</div>
<div>Passed: sun/security/pkcs11/KeyStore/<wbr>Basic.sh</div>
<div>Passed: sun/security/pkcs11/KeyStore/<wbr>ClientAuth.sh</div>
<div>Passed: sun/security/pkcs11/KeyStore/<wbr>SecretKeysBasic.sh</div>
<div>Passed: sun/security/pkcs11/KeyStore/<wbr>Solaris.sh</div>
<div>Passed: sun/security/pkcs11/Mac/<wbr>MacKAT.java</div>
<div>Passed: sun/security/pkcs11/Mac/<wbr>MacSameTest.java</div>
<div>Passed: sun/security/pkcs11/Mac/<wbr>ReinitMac.java</div>
<div>Passed: sun/security/pkcs11/<wbr>MessageDigest/ByteBuffers.java</div>
<div>Passed: sun/security/pkcs11/<wbr>MessageDigest/DigestKAT.java</div>
<div>Passed: sun/security/pkcs11/<wbr>MessageDigest/ReinitDigest.<wbr>java</div>
<div>Passed: sun/security/pkcs11/<wbr>MessageDigest/TestCloning.java</div>
<div>Passed: sun/security/pkcs11/Provider/<wbr>Absolute.java</div>
<div>Passed: sun/security/pkcs11/Provider/<wbr>ConfigQuotedString.sh</div>
<div>Passed: sun/security/pkcs11/Provider/<wbr>ConfigShortPath.java</div>
<div>Passed: sun/security/pkcs11/Provider/<wbr>Login.sh</div>
<div>Passed: sun/security/pkcs11/Provider/<wbr>LoginISE.java</div>
<div>Passed: sun/security/pkcs11/rsa/<wbr>KeyWrap.java</div>
<div>Passed: sun/security/pkcs11/rsa/<wbr>TestCACerts.java</div>
<div>Passed: sun/security/pkcs11/rsa/<wbr>TestKeyFactory.java</div>
<div>Passed: sun/security/pkcs11/rsa/<wbr>TestKeyPairGenerator.java</div>
<div>Passed: sun/security/pkcs11/rsa/<wbr>TestSignatures.java</div>
<div>Passed: sun/security/pkcs11/Secmod/<wbr>AddPrivateKey.java</div>
<div>FAILED: sun/security/pkcs11/Secmod/<wbr>AddTrustedCert.java</div>
<div>Passed: sun/security/pkcs11/Secmod/<wbr>Crypto.java</div>
<div>Passed: sun/security/pkcs11/Secmod/<wbr>GetPrivateKey.java</div>
<div>Passed: sun/security/pkcs11/Secmod/<wbr>JksSetPrivateKey.java</div>
<div>Passed: sun/security/pkcs11/Secmod/<wbr>LoadKeystore.java</div>
<div>Passed: sun/security/pkcs11/Secmod/<wbr>TestNssDbSqlite.java</div>
<div>Passed: sun/security/pkcs11/Secmod/<wbr>TrustAnchors.java</div>
<div>Passed: sun/security/pkcs11/<wbr>SecureRandom/Basic.java</div>
<div>Passed:
sun/security/pkcs11/<wbr>SecureRandom/<wbr>TestDeserialization.java</div>
<div>Passed:
sun/security/pkcs11/Serialize/<wbr>SerializeProvider.java</div>
<div>Passed: sun/security/pkcs11/Signature/<wbr>ByteBuffers.java</div>
<div>Passed: sun/security/pkcs11/Signature/<wbr>ReinitSignature.java</div>
<div>Passed: sun/security/pkcs11/Signature/<wbr>TestDSA.java</div>
<div>Passed: sun/security/pkcs11/Signature/<wbr>TestDSAKeyLength.java</div>
<div>Passed: sun/security/pkcs11/Signature/<wbr>TestRSAKeyLength.java</div>
<div>Passed:
sun/security/pkcs11/sslecc/<wbr>ClientJSSEServerJSSE.java</div>
<div>FAILED: sun/security/pkcs11/tls/<wbr>TestKeyMaterial.java</div>
<div>Passed: sun/security/pkcs11/tls/<wbr>TestLeadingZeroesP11.java</div>
<div>Passed: sun/security/pkcs11/tls/<wbr>TestMasterSecret.java</div>
<div>Passed: sun/security/pkcs11/tls/<wbr>TestPremaster.java</div>
<div>Passed: sun/security/pkcs11/tls/<wbr>TestPRF.java</div>
<div>Passed: sun/security/pkcs11/tls/<wbr>TestTLS12.java</div>
<div>Passed: sun/security/pkcs11/<wbr>SampleTest.java</div>
<div>Test results: passed: 70; failed: 3</div>
<div><br>
</div>
<div>NOTE: failing testcases were already failing on an
unpatched JDK.</div>
<div><br>
</div>
<div>Look forward to your answer.</div>
<div><br>
</div>
<div>Kind regards,</div>
<div>Martin.-</div>
</div>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div>